Differential D3749

Run rc imap over nginx for 2fa with proxy protocol support
ClosedPublic
Actions

Authored by mollekopf on Jul 28 2022, 5:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 28, 6:42 AM

	Unknown Object (File)
	Sat, May 25, 7:10 AM

	Unknown Object (File)
	Fri, May 24, 11:06 AM

	Unknown Object (File)
	Tue, May 21, 6:12 AM

	Unknown Object (File)
	Mon, May 20, 6:44 AM

	Unknown Object (File)
	Sun, May 19, 6:53 AM

	Unknown Object (File)
	Sun, May 19, 2:28 AM

	Unknown Object (File)
	Thu, May 9, 2:29 AM

View All 55 Files

Subscribers

None

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rK8373e36c68f6: Run rc imap over nginx for 2fa with proxy protocol support
rK70ed15887bfa: Run rc imap over nginx for 2fa with proxy protocol support
rK5044e66f9cad: Run rc imap over nginx for 2fa with proxy protocol support
rK15fbcd00cad2: Run rc imap over nginx for 2fa with proxy protocol support
rK903f7774a1f7: Run rc imap over nginx for 2fa with proxy protocol support

Diff Detail

Repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39572
Build 16121: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Jul 28 2022, 5:06 PM

mollekopf created this revision.

Harbormaster completed remote builds in B39569: Diff 10688.Jul 28 2022, 5:06 PM

mollekopf added a reviewer: Restricted Project.Jul 28 2022, 5:08 PM

Removed log message

Harbormaster completed remote builds in B39572: Diff 10691.Jul 28 2022, 5:08 PM

mollekopf added inline comments.Jul 28 2022, 5:09 PM

src/app/Http/Controllers/API/V4/NGINXController.php
158	Alec pointed out that instead of extracting the Proxy-Protocol-Addr here we could set the Client-Ip in NGINX on the request.

mollekopf added inline comments.Sep 1 2022, 2:31 PM

src/app/Http/Controllers/API/V4/NGINXController.php
158	I have tried this, but don't know how to set the client ip on the http subrequest of the mail module if at all possible. So we'll stick with this approach until somebody figures out how to do it differently.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 19 2022, 12:11 PM

Closed by commit rK8373e36c68f6: Run rc imap over nginx for 2fa with proxy protocol support (authored by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

docker/

kolab/

utils/

24-roundcubeconfig.sh

21 lines

nginx/

14 lines

src/

app/

Http/

Controllers/

API/

V4/

NGINXController.php

10 lines

Diff 10691

docker/kolab/utils/24-roundcubeconfig.sh

Loading...

docker/nginx/nginx.conf

Loading...

src/app/Http/Controllers/API/V4/NGINXController.php

Loading...