diff --git a/spec/unit/module_tool/applications/builder_spec.rb b/spec/unit/module_tool/applications/builder_spec.rb index a8ef47bdc..291473db9 100644 --- a/spec/unit/module_tool/applications/builder_spec.rb +++ b/spec/unit/module_tool/applications/builder_spec.rb @@ -1,416 +1,416 @@ require 'spec_helper' require 'puppet/file_system' require 'puppet/module_tool/applications' require 'puppet_spec/modules' describe Puppet::ModuleTool::Applications::Builder do include PuppetSpec::Files let(:path) { tmpdir("working_dir") } let(:module_name) { 'mymodule-mytarball' } let(:version) { '0.0.1' } let(:release_name) { "#{module_name}-#{version}" } let(:tarball) { File.join(path, 'pkg', release_name) + ".tar.gz" } let(:builder) { Puppet::ModuleTool::Applications::Builder.new(path) } shared_examples "a packagable module" do def target_exists?(file) File.exist?(File.join(path, "pkg", "#{module_name}-#{version}", file)) end def build tarrer = mock('tarrer') Puppet::ModuleTool::Tar.expects(:instance).returns(tarrer) Dir.expects(:chdir).with(File.join(path, 'pkg')).yields tarrer.expects(:pack).with(release_name, tarball) builder.run end def create_regular_files Puppet::FileSystem.touch(File.join(path, '.dotfile')) Puppet::FileSystem.touch(File.join(path, 'file.foo')) Puppet::FileSystem.touch(File.join(path, 'REVISION')) Puppet::FileSystem.touch(File.join(path, '~file')) Puppet::FileSystem.touch(File.join(path, '#file')) Puppet::FileSystem.mkpath(File.join(path, 'pkg')) Puppet::FileSystem.mkpath(File.join(path, 'coverage')) Puppet::FileSystem.mkpath(File.join(path, 'sub')) Puppet::FileSystem.touch(File.join(path, 'sub/.dotfile')) Puppet::FileSystem.touch(File.join(path, 'sub/file.foo')) Puppet::FileSystem.touch(File.join(path, 'sub/REVISION')) Puppet::FileSystem.touch(File.join(path, 'sub/~file')) Puppet::FileSystem.touch(File.join(path, 'sub/#file')) Puppet::FileSystem.mkpath(File.join(path, 'sub/pkg')) Puppet::FileSystem.mkpath(File.join(path, 'sub/coverage')) end def create_symlinks Puppet::FileSystem.touch(File.join(path, 'symlinkedfile')) Puppet::FileSystem.symlink(File.join(path, 'symlinkedfile'), File.join(path, 'symlinkfile')) end def create_ignored_files Puppet::FileSystem.touch(File.join(path, 'gitignored.foo')) Puppet::FileSystem.mkpath(File.join(path, 'gitdirectory/sub')) Puppet::FileSystem.touch(File.join(path, 'gitdirectory/gitartifact')) Puppet::FileSystem.touch(File.join(path, 'gitdirectory/gitimportantfile')) Puppet::FileSystem.touch(File.join(path, 'gitdirectory/sub/artifact')) Puppet::FileSystem.touch(File.join(path, 'pmtignored.foo')) Puppet::FileSystem.mkpath(File.join(path, 'pmtdirectory/sub')) Puppet::FileSystem.touch(File.join(path, 'pmtdirectory/pmtimportantfile')) Puppet::FileSystem.touch(File.join(path, 'pmtdirectory/pmtartifact')) Puppet::FileSystem.touch(File.join(path, 'pmtdirectory/sub/artifact')) end def create_pmtignore_file Puppet::FileSystem.open(File.join(path, '.pmtignore'), 0600, 'w') do |f| f << <<-PMTIGNORE pmtignored.* pmtdirectory/sub/** pmtdirectory/pmt* !pmtimportantfile PMTIGNORE end end def create_gitignore_file Puppet::FileSystem.open(File.join(path, '.gitignore'), 0600, 'w') do |f| f << <<-GITIGNORE gitignored.* gitdirectory/sub/** gitdirectory/git* !gitimportantfile GITIGNORE end end def create_symlink_gitignore_file Puppet::FileSystem.open(File.join(path, '.gitignore'), 0600, 'w') do |f| f << <<-GITIGNORE symlinkfile GITIGNORE end end shared_examples "regular files are present" do it "has metadata" do expect(target_exists?('metadata.json')).to eq true end it "has checksums" do expect(target_exists?('checksums.json')).to eq true end it "copies regular files" do expect(target_exists?('file.foo')).to eq true end end shared_examples "default artifacts are removed in module dir but not in subdirs" do it "ignores dotfiles" do expect(target_exists?('.dotfile')).to eq false expect(target_exists?('sub/.dotfile')).to eq true end it "does not have .gitignore" do expect(target_exists?('.gitignore')).to eq false end it "does not have .pmtignore" do expect(target_exists?('.pmtignore')).to eq false end it "does not have pkg" do expect(target_exists?('pkg')).to eq false expect(target_exists?('sub/pkg')).to eq true end it "does not have coverage" do expect(target_exists?('coverage')).to eq false expect(target_exists?('sub/coverage')).to eq true end it "does not have REVISION" do expect(target_exists?('REVISION')).to eq false expect(target_exists?('sub/REVISION')).to eq true end it "does not have ~files" do expect(target_exists?('~file')).to eq false expect(target_exists?('sub/~file')).to eq true end it "does not have #files" do expect(target_exists?('#file')).to eq false expect(target_exists?('sub/#file')).to eq true end end shared_examples "gitignored files are present" do it "leaves regular files" do expect(target_exists?('gitignored.foo')).to eq true end it "leaves directories" do expect(target_exists?('gitdirectory')).to eq true end it "leaves files in directories" do expect(target_exists?('gitdirectory/gitartifact')).to eq true end it "leaves exceptional files" do expect(target_exists?('gitdirectory/gitimportantfile')).to eq true end it "leaves subdirectories" do expect(target_exists?('gitdirectory/sub')).to eq true end it "leaves files in subdirectories" do expect(target_exists?('gitdirectory/sub/artifact')).to eq true end end shared_examples "gitignored files are not present" do it "ignores regular files" do expect(target_exists?('gitignored.foo')).to eq false end it "ignores directories" do expect(target_exists?('gitdirectory')).to eq true end it "ignores files in directories" do expect(target_exists?('gitdirectory/gitartifact')).to eq false end it "copies exceptional files" do expect(target_exists?('gitdirectory/gitimportantfile')).to eq true end it "ignores subdirectories" do expect(target_exists?('gitdirectory/sub')).to eq false end it "ignores files in subdirectories" do expect(target_exists?('gitdirectory/sub/artifact')).to eq false end end shared_examples "pmtignored files are present" do it "leaves regular files" do expect(target_exists?('pmtignored.foo')).to eq true end it "leaves directories" do expect(target_exists?('pmtdirectory')).to eq true end it "ignores files in directories" do expect(target_exists?('pmtdirectory/pmtartifact')).to eq true end it "leaves exceptional files" do expect(target_exists?('pmtdirectory/pmtimportantfile')).to eq true end it "leaves subdirectories" do expect(target_exists?('pmtdirectory/sub')).to eq true end it "leaves files in subdirectories" do expect(target_exists?('pmtdirectory/sub/artifact')).to eq true end end shared_examples "pmtignored files are not present" do it "ignores regular files" do expect(target_exists?('pmtignored.foo')).to eq false end it "ignores directories" do expect(target_exists?('pmtdirectory')).to eq true end it "copies exceptional files" do expect(target_exists?('pmtdirectory/pmtimportantfile')).to eq true end it "ignores files in directories" do expect(target_exists?('pmtdirectory/pmtartifact')).to eq false end it "ignores subdirectories" do expect(target_exists?('pmtdirectory/sub')).to eq false end it "ignores files in subdirectories" do expect(target_exists?('pmtdirectory/sub/artifact')).to eq false end end context "with no ignore files" do before :each do create_regular_files create_ignored_files build end it_behaves_like "regular files are present" it_behaves_like "default artifacts are removed in module dir but not in subdirs" it_behaves_like "pmtignored files are present" it_behaves_like "gitignored files are present" end context "with .gitignore file" do before :each do create_regular_files create_ignored_files create_gitignore_file build end it_behaves_like "regular files are present" it_behaves_like "default artifacts are removed in module dir but not in subdirs" it_behaves_like "pmtignored files are present" it_behaves_like "gitignored files are not present" end context "with .pmtignore file" do before :each do create_regular_files create_ignored_files create_pmtignore_file build end it_behaves_like "regular files are present" it_behaves_like "default artifacts are removed in module dir but not in subdirs" it_behaves_like "gitignored files are present" it_behaves_like "pmtignored files are not present" end context "with .pmtignore and .gitignore file" do before :each do create_regular_files create_ignored_files create_pmtignore_file create_gitignore_file build end it_behaves_like "regular files are present" it_behaves_like "default artifacts are removed in module dir but not in subdirs" it_behaves_like "gitignored files are present" it_behaves_like "pmtignored files are not present" end - context "with unignored symlinks" do + context "with unignored symlinks", :if => Puppet.features.manages_symlinks? do before :each do create_regular_files create_symlinks create_ignored_files end it "give an error about symlinks" do expect { builder.run }.to raise_error end end - context "with .gitignore file and ignored symlinks" do + context "with .gitignore file and ignored symlinks", :if => Puppet.features.manages_symlinks? do before :each do create_regular_files create_symlinks create_ignored_files create_symlink_gitignore_file end it "does not give an error about symlinks" do expect { build }.not_to raise_error end end end context 'with metadata.json' do before :each do File.open(File.join(path, 'metadata.json'), 'w') do |f| f.puts({ "name" => "#{module_name}", "version" => "#{version}", "source" => "http://github.com/testing/#{module_name}", "author" => "testing", "license" => "Apache License Version 2.0", "summary" => "Puppet testing module", "description" => "This module can be used for basic testing", "project_page" => "http://github.com/testing/#{module_name}" }.to_json) end end it_behaves_like "a packagable module" it "does not package with a symlink", :if => Puppet.features.manages_symlinks? do FileUtils.touch(File.join(path, 'tempfile')) Puppet::FileSystem.symlink(File.join(path, 'tempfile'), File.join(path, 'tempfile2')) expect { builder.run }.to raise_error Puppet::ModuleTool::Errors::ModuleToolError, /symlinks/i end it "does not package with a symlink in a subdir", :if => Puppet.features.manages_symlinks? do FileUtils.mkdir(File.join(path, 'manifests')) FileUtils.touch(File.join(path, 'manifests/tempfile.pp')) Puppet::FileSystem.symlink(File.join(path, 'manifests/tempfile.pp'), File.join(path, 'manifests/tempfile2.pp')) expect { builder.run }.to raise_error Puppet::ModuleTool::Errors::ModuleToolError, /symlinks/i end end context 'with metadata.json containing checksums' do before :each do File.open(File.join(path, 'metadata.json'), 'w') do |f| f.puts({ "name" => "#{module_name}", "version" => "#{version}", "source" => "http://github.com/testing/#{module_name}", "author" => "testing", "license" => "Apache License Version 2.0", "summary" => "Puppet testing module", "description" => "This module can be used for basic testing", "project_page" => "http://github.com/testing/#{module_name}", "checksums" => {"README.md" => "deadbeef"} }.to_json) end end it_behaves_like "a packagable module" end context 'with Modulefile' do before :each do File.open(File.join(path, 'Modulefile'), 'w') do |f| f.write <<-MODULEFILE name '#{module_name}' version '#{version}' source 'http://github.com/testing/#{module_name}' author 'testing' license 'Apache License Version 2.0' summary 'Puppet testing module' description 'This module can be used for basic testing' project_page 'http://github.com/testing/#{module_name}' MODULEFILE end end it_behaves_like "a packagable module" end end