diff --git a/spec/unit/provider/package/pip_spec.rb b/spec/unit/provider/package/pip_spec.rb index d8c38d427..2213b6f63 100755 --- a/spec/unit/provider/package/pip_spec.rb +++ b/spec/unit/provider/package/pip_spec.rb @@ -1,223 +1,227 @@ #! /usr/bin/env ruby require 'spec_helper' provider_class = Puppet::Type.type(:package).provider(:pip) +osfamilies = { 'RedHat' => 'pip-python', 'Not RedHat' => 'pip' } describe provider_class do before do @resource = Puppet::Resource.new(:package, "fake_package") @provider = provider_class.new(@resource) @client = stub_everything('client') @client.stubs(:call).with('package_releases', 'real_package').returns(["1.3", "1.2.5", "1.2.4"]) @client.stubs(:call).with('package_releases', 'fake_package').returns([]) XMLRPC::Client.stubs(:new2).returns(@client) end describe "parse" do it "should return a hash on valid input" do provider_class.parse("real_package==1.2.5").should == { :ensure => "1.2.5", :name => "real_package", :provider => :pip, } end it "should return nil on invalid input" do provider_class.parse("foo").should == nil end end describe "cmd" do - it "should return pip-python on RedHat systems" do Facter.stubs(:value).with(:osfamily).returns("RedHat") provider_class.cmd.should == 'pip-python' end it "should return pip by default" do Facter.stubs(:value).with(:osfamily).returns("Not RedHat") provider_class.cmd.should == 'pip' end end describe "instances" do - it "should return an array when pip is present" do - provider_class.expects(:which).with('pip').returns("/fake/bin/pip") - p = stub("process") - p.expects(:collect).yields("real_package==1.2.5") - provider_class.expects(:execpipe).with("/fake/bin/pip freeze").yields(p) - provider_class.instances - end + osfamilies.each do |osfamily, pip_cmd| + it "should return an array on #{osfamily} when #{pip_cmd} is present" do + Facter.stubs(:value).with(:osfamily).returns(osfamily) + provider_class.expects(:which).with(pip_cmd).returns("/fake/bin/pip") + p = stub("process") + p.expects(:collect).yields("real_package==1.2.5") + provider_class.expects(:execpipe).with("/fake/bin/pip freeze").yields(p) + provider_class.instances + end - it "should return an empty array when pip is missing" do - provider_class.expects(:which).with('pip').returns nil - provider_class.instances.should == [] + it "should return an empty array on #{osfamily} when #{pip_cmd} is missing" do + Facter.stubs(:value).with(:osfamily).returns(osfamily) + provider_class.expects(:which).with(pip_cmd).returns nil + provider_class.instances.should == [] + end end end describe "query" do before do @resource[:name] = "real_package" end it "should return a hash when pip and the package are present" do provider_class.expects(:instances).returns [provider_class.new({ :ensure => "1.2.5", :name => "real_package", :provider => :pip, })] @provider.query.should == { :ensure => "1.2.5", :name => "real_package", :provider => :pip, } end it "should return nil when the package is missing" do provider_class.expects(:instances).returns [] @provider.query.should == nil end end describe "latest" do it "should find a version number for real_package" do @resource[:name] = "real_package" @provider.latest.should_not == nil end it "should not find a version number for fake_package" do @resource[:name] = "fake_package" @provider.latest.should == nil end it "should handle a timeout gracefully" do @resource[:name] = "fake_package" @client.stubs(:call).raises(Timeout::Error) lambda { @provider.latest }.should raise_error(Puppet::Error) end end describe "install" do before do @resource[:name] = "fake_package" @url = "git+https://example.com/fake_package.git" end it "should install" do @resource[:ensure] = :installed @resource[:source] = nil @provider.expects(:lazy_pip). with("install", '-q', "fake_package") @provider.install end it "omits the -e flag (GH-1256)" do # The -e flag makes the provider non-idempotent @resource[:ensure] = :installed @resource[:source] = @url @provider.expects(:lazy_pip).with() do |*args| not args.include?("-e") end @provider.install end it "should install from SCM" do @resource[:ensure] = :installed @resource[:source] = @url @provider.expects(:lazy_pip). with("install", '-q', "#{@url}#egg=fake_package") @provider.install end it "should install a particular SCM revision" do @resource[:ensure] = "0123456" @resource[:source] = @url @provider.expects(:lazy_pip). with("install", "-q", "#{@url}@0123456#egg=fake_package") @provider.install end it "should install a particular version" do @resource[:ensure] = "0.0.0" @resource[:source] = nil @provider.expects(:lazy_pip).with("install", "-q", "fake_package==0.0.0") @provider.install end it "should upgrade" do @resource[:ensure] = :latest @resource[:source] = nil @provider.expects(:lazy_pip). with("install", "-q", "--upgrade", "fake_package") @provider.install end end describe "uninstall" do it "should uninstall" do @resource[:name] = "fake_package" @provider.expects(:lazy_pip). with('uninstall', '-y', '-q', 'fake_package') @provider.uninstall end end describe "update" do it "should just call install" do @provider.expects(:install).returns(nil) @provider.update end end describe "lazy_pip" do it "should succeed if pip is present" do @provider.stubs(:pip).returns(nil) @provider.method(:lazy_pip).call "freeze" end - it "should retry if pip has not yet been found" do - @provider.expects(:pip).twice.with('freeze').raises(NoMethodError).then.returns(nil) - @provider.expects(:which).with('pip').returns("/fake/bin/pip") - @provider.method(:lazy_pip).call "freeze" - end + osfamilies.each do |osfamily, pip_cmd| + it "should retry on #{osfamily} if #{pip_cmd} has not yet been found" do + Facter.stubs(:value).with(:osfamily).returns(osfamily) + @provider.expects(:pip).twice.with('freeze').raises(NoMethodError).then.returns(nil) + @provider.expects(:which).with(pip_cmd).returns("/fake/bin/pip") + @provider.method(:lazy_pip).call "freeze" + end - it "should fail if pip is missing" do - @provider.expects(:pip).with('freeze').raises(NoMethodError) - @provider.expects(:which).with('pip').returns(nil) - expect { @provider.method(:lazy_pip).call("freeze") }.to raise_error(NoMethodError) - end + it "should fail on #{osfamily} if #{pip_cmd} is missing" do + Facter.stubs(:value).with(:osfamily).returns(osfamily) + @provider.expects(:pip).with('freeze').raises(NoMethodError) + @provider.expects(:which).with(pip_cmd).returns(nil) + expect { @provider.method(:lazy_pip).call("freeze") }.to raise_error(NoMethodError) + end - it "should output a useful error message if pip is missing" do - @provider.expects(:pip).with('freeze').raises(NoMethodError) - @provider.expects(:which).with('pip').returns(nil) - expect { @provider.method(:lazy_pip).call("freeze") }. - to raise_error(NoMethodError, 'Could not locate the pip command.') - end + it "should output a useful error message on #{osfamily} if #{pip_cmd} is missing" do + Facter.stubs(:value).with(:osfamily).returns(osfamily) + @provider.expects(:pip).with('freeze').raises(NoMethodError) + @provider.expects(:which).with(pip_cmd).returns(nil) + expect { @provider.method(:lazy_pip).call("freeze") }. + to raise_error(NoMethodError, 'Could not locate the pip command.') + end - it "should use pip-python when ran on a RedHat system", :if => Facter.value(:osfamily) == 'RedHat' do - @provider.expects(:pip).twice.with('freeze').raises(NoMethodError).then.returns(nil) - @provider.expects(:which).with('pip-python').returns("/fake/bin/pip-python") - @provider.method(:lazy_pip).call "freeze" end end end