Working 2FA
16b688d80237Unpublished
Actions

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Working 2FA

Details

Provenance

machniak	Authored on Mar 27 2020, 9:46 AM
machniak	Pushed on Mar 27 2020, 9:49 AM

Differential Revision

D1075: 2FA - initial, non-working code

Parents

rK62557f6f2cfa: 2FA - initial, non-working code

Branches

Unknown

Tags

Unknown

Event Timeline

machniak committed rK16b688d80237: Working 2FA (authored by machniak).Mar 27 2020, 9:46 AM

in addition, the 2FA checkbox could use an explicit (as in not hidden behind the info button) hint
that this only works when the users also sets it up in roundcube,
as well as a hint that this will disable the usage of external clients for now

/src/resources/vue/Login.vue
19	I'd still prefer a second page for 2FA form that is only shown when 2FA is enabled but the hint makes it work for now.
23	I would not add an icon to this button. Same goes for a log of buttons in the UI. Different topic though.

In rK16b688d80237f2f24b9e01bfca7e692b2d0e6c1b#511210, @bohlender wrote:

in addition, the 2FA checkbox could use an explicit (as in not hidden behind the info button) hint
that this only works when the users also sets it up in roundcube,
as well as a hint that this will disable the usage of external clients for now

That text would be quite long, so I'm not sure I'd like it. Maybe if it would be very short (a single line) "* read here about 2-Factor implications." with a link to KB?

As for the logon form, we should maybe separate the 2FA input from the first two inputs, e.g. putting the hint above the input. Still, this is different than what Roundcube does, but I'm not sure how big of an issue it is. We of course can leave it for later.