Can you explain "Smarty issue fixed by hand" in detail? What's the issue and how did you fix it?

Addressed comments

Almost there. tests/Browser/WalletTest.php needs an update too.

Test, cleanup

Fixed in master

• Workaround KTOR client bug, add development commands to send push notifications

Maybe something like this:

--- a/cyruslib.py
+++ b/cyruslib.py
@@ -885,6 +885,7 @@ class CYRUS:
             annotation = annotation.strip()
             tokens = tokenize(annotation)
             folder = tokens[0]
+            mailbox = ensure_binary(mailbox)

I think everything besides the Docker FROM changes can be merged because it doesn't impact anything existing either way.

See my take in D4794: Fold WalletCharge and WalletCheck into one

Cleanup

Removed print statement

To be able to validate things we now just validate first, and then create everything, and bail out if user or domain are preexisting.
There's doesn't seem to really be a point in converting existing users.

Fixed mail options

See D4791: Add tenant context to signup codes

Adapt to recent changes

Fixed, sorry about the downtime.

https://phorge.apps.ocp04.ait-msp-infra.net/T265

it's not, and I'm also not sure if this really solves anything since we actually try to keep the balance around 10 CHF (I think?). Maybe the better solution would be to just prominently display a warning that the user is being rate limited.

• Complete tenant-independence in CLI commands
• Fix regression, cleanup

Be careful when deploying this. Make sure the queue is empty.

We want to use app.password only when *not* in production of course

This changes nothing if we run the jobs on the main system. But I agree we need a tenant context. See T264 in Phorge.

This make app.passphrase to be used only on production, which is wrong.

I don't think this makes sense, because the same is done by the observer already.

I used this to create new users on demoresller.kolab.klab.cc and I don't see why not.