Page MenuHomePhorge
Feed All Stories

Jun 15 2020

machniak committed rKfbf3f75e27ea: Make sure we bill for entitlements that are deleted (authored by machniak).
Make sure we bill for entitlements that are deleted
Jun 15 2020, 3:19 PM
machniak closed D1297: Make sure we bill for entitlements that are deleted.
Jun 15 2020, 3:19 PM
vanmeeuwen accepted D1378: Add copyright and company details in the page footer.
Jun 15 2020, 3:12 PM
machniak updated the diff for D1378: Add copyright and company details in the page footer.
  • Hardcode copyright in the footer
Jun 15 2020, 3:09 PM
vanmeeuwen accepted D1384: Mobile UI fixes.
Jun 15 2020, 3:04 PM
vanmeeuwen accepted D1366: Fix transaction description for domain entitlements.
Jun 15 2020, 2:59 PM
vanmeeuwen requested changes to D1378: Add copyright and company details in the page footer.

The copyright is not subject to configuration to be honest.

Jun 15 2020, 2:58 PM
vanmeeuwen added a comment to D1366: Fix transaction description for domain entitlements.

With question ;-)

Jun 15 2020, 2:56 PM
vanmeeuwen accepted D1372: Display a notice about the wallet state (Bifrost#T348752).
Jun 15 2020, 2:56 PM
vanmeeuwen requested changes to D1366: Fix transaction description for domain entitlements.

One question for the whodunnit.

Jun 15 2020, 2:53 PM
vanmeeuwen removed a reviewer for D1297: Make sure we bill for entitlements that are deleted: machniak.
Jun 15 2020, 2:50 PM
vanmeeuwen accepted D1297: Make sure we bill for entitlements that are deleted.
Jun 15 2020, 2:49 PM
machniak updated the diff for D1384: Mobile UI fixes.
  • Add real favicon.ico
Jun 15 2020, 2:12 PM
machniak requested review of D1384: Mobile UI fixes.
Jun 15 2020, 1:03 PM

Jun 14 2020

coronalover47 edited a custom field on coronalover47.
Jun 14 2020, 12:01 PM
machniak committed rK1e03ad3917a9: Bump js dependencies, fix linting issues (authored by machniak).
Bump js dependencies, fix linting issues
Jun 14 2020, 8:34 AM

Jun 13 2020

umashankar123 added a watcher for PyKolab Developers: umashankar123.
Jun 13 2020, 1:32 PM
umashankar123 renamed T1290: Folders not subscribed for new users in kolab 3.4 from Folders not subscribed for new users to Folders not subscribed for new users in kolab 3.4.
Jun 13 2020, 11:06 AM · Bug Reports
umashankar123 added a comment to T1290: Folders not subscribed for new users in kolab 3.4.

we are at kolab 3.4 . during creating new user Archive folder is not getting created.. Initially it was creating only Inbox. after doing repair of annotations.db from twoskip to skiplist . It again started created all folders except Archive. Need the solution.

Jun 13 2020, 10:55 AM · Bug Reports
TRAVELOFARE edited a custom field on TRAVELOFARE.
Jun 13 2020, 10:46 AM
Virgoacp edited a custom field on Virgoacp.
Jun 13 2020, 10:04 AM
umashankar123 added a watcher for Roundcube Kolab Plugins Developers: umashankar123.
Jun 13 2020, 8:13 AM
umashankar123 added a watcher for Admin Developers: umashankar123.
Jun 13 2020, 7:58 AM

Jun 12 2020

americanfootball added a comment to T5896: Updating how-to secure kolab server.
Jun 12 2020, 3:49 PM · Documentation, Bug Reports
machniak requested review of D1378: Add copyright and company details in the page footer.
Jun 12 2020, 12:19 PM
machniak updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Rollback transactions on exceptions
  • Performance optimization
Jun 12 2020, 11:01 AM
machniak added a comment to D1051: improve wallet layout.

Partially implemented in https://git.kolab.org/D1372 and we decided to not implement the costs overview table. So, I think this differential could be abandoned.

Jun 12 2020, 8:59 AM
machniak requested review of D1372: Display a notice about the wallet state (Bifrost#T348752).
Jun 12 2020, 8:55 AM

Jun 11 2020

xmas113 created T5902: Calendar.
Jun 11 2020, 4:22 PM
machniak updated the summary of D1366: Fix transaction description for domain entitlements.
Jun 11 2020, 9:20 AM
machniak requested review of D1366: Fix transaction description for domain entitlements.
Jun 11 2020, 9:16 AM

Jun 10 2020

machniak committed rKc4818aadb932: Small css fix (authored by machniak).
Small css fix
Jun 10 2020, 3:10 PM
machniak committed rK5b736c1c9b50: Fix font-size on small elements (authored by machniak).
Fix font-size on small elements
Jun 10 2020, 3:10 PM
machniak committed rK5819373d54ff: Improve error handling on signup welcome page (authored by machniak).
Improve error handling on signup welcome page
Jun 10 2020, 3:10 PM
Bookmykart updated Bookmykart.
Jun 10 2020, 2:01 PM
machniak committed rK98d3e8702b7e: Fix linting issues and a regression in browser tests (authored by machniak).
Fix linting issues and a regression in browser tests
Jun 10 2020, 12:31 PM
machniak committed rKf4537ed38a96: VAT on Receipts (authored by machniak).
VAT on Receipts
Jun 10 2020, 11:56 AM
machniak closed D1327: VAT on Receipts.
Jun 10 2020, 11:56 AM
machniak committed rK92c7f9f21811: Receipts UI (authored by machniak).
Receipts UI
Jun 10 2020, 11:56 AM
machniak closed D1348: Receipts UI.
Jun 10 2020, 11:56 AM
machniak updated the diff for D1348: Receipts UI.
  • Fix History tab after rabease
Jun 10 2020, 11:54 AM
machniak updated the diff for D1348: Receipts UI.
  • Use YYYY-MM format in receipt filename
  • Rebase
Jun 10 2020, 11:45 AM
machniak committed rK90da82738276: Transaction log in admin UI (authored by machniak).
Transaction log in admin UI
Jun 10 2020, 11:41 AM
machniak closed D1360: Transaction log in admin UI.
Jun 10 2020, 11:41 AM
machniak committed rKda13578ce560: Wallet magic (authored by machniak).
Wallet magic
Jun 10 2020, 11:41 AM
machniak closed D1150: Wallet magic.
Jun 10 2020, 11:41 AM
machniak committed rK534d00000831: Cherry-picked contents from hkccp-import (authored by vanmeeuwen).
Cherry-picked contents from hkccp-import
Jun 10 2020, 11:41 AM
machniak closed D1291: Cherry-picked contents from hkccp-import.
Jun 10 2020, 11:41 AM
machniak committed rK0481c595510a: Add plain text parts to email (authored by machniak).
Add plain text parts to email
Jun 10 2020, 11:41 AM
machniak closed D1354: Add plain text parts to email.
Jun 10 2020, 11:41 AM
vanmeeuwen accepted D1360: Transaction log in admin UI.
Jun 10 2020, 11:32 AM
vanmeeuwen accepted D1354: Add plain text parts to email.
Jun 10 2020, 11:31 AM
vanmeeuwen accepted D1150: Wallet magic.
Jun 10 2020, 11:30 AM
vanmeeuwen accepted D1348: Receipts UI.
Jun 10 2020, 11:29 AM
vanmeeuwen accepted D1327: VAT on Receipts.
Jun 10 2020, 11:28 AM
machniak added inline comments to D1360: Transaction log in admin UI.
Jun 10 2020, 10:58 AM
bohlender added inline comments to D1360: Transaction log in admin UI.
Jun 10 2020, 10:14 AM
machniak updated the diff for D1360: Transaction log in admin UI.
  • Small code improvements
Jun 10 2020, 8:59 AM
machniak requested review of D1360: Transaction log in admin UI.
Jun 10 2020, 8:14 AM
indyaspeak updated indyaspeak.
Jun 10 2020, 7:18 AM

Jun 9 2020

ezrankings edited a custom field on ezrankings.
Jun 9 2020, 4:57 PM
ezrankings updated ezrankings.
Jun 9 2020, 4:56 PM
machniak committed rK7dc1e3fa2ee8: Limit number of records the test works with, code improvements (authored by machniak).
Limit number of records the test works with, code improvements
Jun 9 2020, 11:12 AM
machniak requested review of D1354: Add plain text parts to email.
Jun 9 2020, 10:47 AM

Jun 8 2020

machniak updated the diff for D1348: Receipts UI.
  • Use YYYY-MM format in receipt filename
Jun 8 2020, 12:03 PM
machniak requested review of D1348: Receipts UI.
Jun 8 2020, 8:49 AM

Jun 7 2020

dhoffend abandoned D1342: add json url to apache example configuration.

double diff

Jun 7 2020, 11:51 PM
dhoffend updated the diff for D1339: add json url to apache example configuration.

Removed double Alias

Jun 7 2020, 11:50 PM
dhoffend requested review of D1342: add json url to apache example configuration.
Jun 7 2020, 11:49 PM
dhoffend requested review of D1339: add json url to apache example configuration.
Jun 7 2020, 11:48 PM
dhoffend requested review of D1333: add group.alias translation.
Jun 7 2020, 11:10 PM
hotmanjikaranchi95 updated hotmanjikaranchi95.
Jun 7 2020, 6:50 PM

Jun 5 2020

machniak requested changes to D1150: Wallet magic.

@vanmeeuwen, I rebased, fixed obvious bugs and refactored the code so now we have Wallet::balanceLastsUntil() that we need tests for in tests/Feature/WalletTest::testBalanceLastsUntil().

Jun 5 2020, 1:47 PM
machniak updated the diff for D1150: Wallet magic.
  • Fix error due to missing use statements
  • Create Wallet::balanceLastsUntil()
Jun 5 2020, 1:44 PM
machniak added inline comments to D1297: Make sure we bill for entitlements that are deleted.
Jun 5 2020, 1:09 PM
machniak requested changes to D1297: Make sure we bill for entitlements that are deleted.

This learned us that an exception does not rollback uncommitted transactions. Here's a general fix for this issue:

--- a/src/app/Exceptions/Handler.php
+++ b/src/app/Exceptions/Handler.php
@@ -5,6 +5,7 @@ namespace App\Exceptions;
 use Exception;
 use Illuminate\Auth\AuthenticationException;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Illuminate\Support\Facades\DB;
Jun 5 2020, 12:50 PM
machniak committed rK35814db70a9c: Fix test failing when executed more than once (authored by machniak).
Fix test failing when executed more than once
Jun 5 2020, 9:34 AM
machniak accepted D1291: Cherry-picked contents from hkccp-import.

My comments to src/app/Domain.php were not addressed, but it's not critical.

Jun 5 2020, 9:01 AM
machniak updated the diff for D1327: VAT on Receipts.
  • Render fake receipt with VAT
Jun 5 2020, 8:26 AM

Jun 4 2020

machniak committed rK279da5dfbdc1: Fix regression, improve button labels (authored by machniak).
Fix regression, improve button labels
Jun 4 2020, 4:22 PM
machniak requested review of D1327: VAT on Receipts.
Jun 4 2020, 3:07 PM
machniak committed rK10f2840186b8: Wallet history (authored by machniak).
Wallet history
Jun 4 2020, 1:59 PM
machniak closed D1321: Wallet history.
Jun 4 2020, 1:59 PM
machniak updated the diff for D1321: Wallet history.
  • Top-up -> Payment
Jun 4 2020, 1:58 PM
bohlender added inline comments to D1321: Wallet history.
Jun 4 2020, 1:15 PM
bohlender added a comment to D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).

Just one labeling issue were we could be clearer. The rest looks good

Jun 4 2020, 1:05 PM
machniak committed rK9b606244c719: Support: Awarding a bonus or penalty (Bifrost#T315896) (authored by machniak).
Support: Awarding a bonus or penalty (Bifrost#T315896)
Jun 4 2020, 12:53 PM
machniak closed D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
Jun 4 2020, 12:53 PM
vanmeeuwen accepted D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
Jun 4 2020, 12:49 PM
machniak requested review of D1321: Wallet history.
Jun 4 2020, 12:47 PM
mollekopf abandoned D1315: Return an empty body element for empty descriptions.

I'm abandoning this revision for now.

Jun 4 2020, 12:26 PM
machniak committed rK5df6db72a947: Receipt document (html and pdf) (authored by machniak).
Receipt document (html and pdf)
Jun 4 2020, 10:34 AM
machniak closed D1309: Receipt document (html and pdf).
Jun 4 2020, 10:33 AM
machniak added a comment to D1315: Return an empty body element for empty descriptions.

The spec. says Body is optional. https://docs.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-ascal/70161e94-3b50-4d20-8c4d-e3ca608f9dc8

Jun 4 2020, 9:37 AM
mollekopf requested review of D1315: Return an empty body element for empty descriptions.
Jun 4 2020, 9:11 AM

Jun 3 2020

vanmeeuwen accepted D1309: Receipt document (html and pdf).
Jun 3 2020, 12:54 PM
machniak committed rKc4f6f1b8b280: Wallet charge: top-ups and notifications (authored by machniak).
Wallet charge: top-ups and notifications
Jun 3 2020, 12:27 PM
machniak closed D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 12:26 PM
vanmeeuwen accepted D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 12:18 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Fix typo
Jun 3 2020, 12:14 PM