Page MenuHomePhorge
Feed All Stories

Jan 13 2022

mollekopf added inline comments to D3280: roundcube config changes.
Jan 13 2022, 9:30 AM

Jan 12 2022

Neustradamus added a comment to T6085: SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) supports.

In first, I wish you a Happy New Year!

Jan 12 2022, 2:39 PM · Architecture & Design
Neustradamus updated the task description for T6085: SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) supports.
Jan 12 2022, 2:37 PM · Architecture & Design
machniak accepted D2984: Proxy authorization for irony/syncroton.
Jan 12 2022, 7:55 AM
machniak added a comment to D3289: .arclint config.

I'd prefer .arc folder instead of phabricator.

Jan 12 2022, 7:51 AM
machniak requested changes to D3280: roundcube config changes.
Jan 12 2022, 7:49 AM
mollekopf updated the summary of D3029: CompanionApp support.
Jan 12 2022, 12:29 AM
mollekopf retitled D3029: CompanionApp support from CompanionApp WIP
Jan 12 2022, 12:28 AM
mollekopf added a reviewer for D3295: Script to inject a mime message into a mailbox: Restricted Project.
Jan 12 2022, 12:21 AM
mollekopf added a reviewer for D3292: Import mailbox script: Restricted Project.
Jan 12 2022, 12:21 AM
mollekopf added a reviewer for D3289: .arclint config: Restricted Project.
Jan 12 2022, 12:20 AM
mollekopf added a reviewer for D3283: Improve 09-enable-debugging: Restricted Project.
Jan 12 2022, 12:20 AM
mollekopf added a reviewer for D3280: roundcube config changes: Restricted Project.
Jan 12 2022, 12:20 AM
mollekopf added a reviewer for D3277: Ignore the inetuserstatus for now: Restricted Project.
Jan 12 2022, 12:19 AM
mollekopf added a reviewer for D3274: Enable debugging for wallace as well.: Restricted Project.
Jan 12 2022, 12:19 AM
mollekopf added a reviewer for D3271: Adjust the base dns for calendar.inc.php as well.: Restricted Project.
Jan 12 2022, 12:18 AM
mollekopf updated subscribers of D3268: Set all require environment variables for the kolab container.
Jan 12 2022, 12:18 AM
mollekopf added a reviewer for D3268: Set all require environment variables for the kolab container: Restricted Project.
Jan 12 2022, 12:18 AM
mollekopf retitled D3202: Added a patching mechanism from Added a patching mechanism This allows to patch the system during setup by creating a docker/kolab/utils/patches directory, adding some patches there, and then customizing the patch-system.sh script, resulting in the system getting patched when...
Jan 12 2022, 12:17 AM
mollekopf requested review of D3295: Script to inject a mime message into a mailbox.
Jan 12 2022, 12:14 AM
mollekopf requested review of D3292: Import mailbox script.
Jan 12 2022, 12:14 AM
mollekopf updated the diff for D3262: Enable phpstan on resources and fix duplicate entry.

Rebased

Jan 12 2022, 12:14 AM
mollekopf requested review of D3289: .arclint config.
Jan 12 2022, 12:13 AM
mollekopf updated the diff for D3256: Added a phpcs script.

Rebasing

Jan 12 2022, 12:08 AM
mollekopf requested review of D3283: Improve 09-enable-debugging.
Jan 12 2022, 12:07 AM
mollekopf updated the diff for D3208: Kolab development environment.

Cleanup

Jan 12 2022, 12:07 AM
mollekopf updated the diff for D3205: "production" meet server deployment.

Rebasing

Jan 12 2022, 12:07 AM
mollekopf requested review of D3280: roundcube config changes.
Jan 12 2022, 12:07 AM
mollekopf requested review of D3277: Ignore the inetuserstatus for now.
Jan 12 2022, 12:07 AM
mollekopf requested review of D3274: Enable debugging for wallace as well..
Jan 12 2022, 12:07 AM
mollekopf requested review of D3271: Adjust the base dns for calendar.inc.php as well..
Jan 12 2022, 12:07 AM
mollekopf requested review of D3268: Set all require environment variables for the kolab container.
Jan 12 2022, 12:07 AM
mollekopf updated the diff for D3202: Added a patching mechanism .
  1. Updating D3202: Added a patching mechanism
Jan 12 2022, 12:07 AM
mollekopf updated the diff for D3026: Make kolab deployment ready to install on a linode.

Fixup

Jan 12 2022, 12:06 AM

Jan 11 2022

mollekopf added a reviewer for D3262: Enable phpstan on resources and fix duplicate entry: Restricted Project.
Jan 11 2022, 10:37 PM
mollekopf requested review of D3262: Enable phpstan on resources and fix duplicate entry.
Jan 11 2022, 10:37 PM
mollekopf updated the diff for D2984: Proxy authorization for irony/syncroton.

phpcs fixes

Jan 11 2022, 10:22 PM
mollekopf updated the diff for D2978: Mediasoup based Kolab Meet.

phpcs fixes

Jan 11 2022, 10:21 PM
sicherha committed rP16bbda7fa28a: [Python 3] Use new exception syntax, part 2 (authored by sicherha).
[Python 3] Use new exception syntax, part 2
Jan 11 2022, 9:09 PM
sicherha closed D3250: [Python 3] Use new exception syntax, part 2.
Jan 11 2022, 9:09 PM
mollekopf added a reviewer for D3256: Added a phpcs script: Restricted Project.

Just like what we have for phpstan.

Jan 11 2022, 8:59 PM
mollekopf requested review of D3256: Added a phpcs script.
Jan 11 2022, 8:59 PM
mollekopf updated the diff for D3029: CompanionApp support.

Fixed some phpstan complaints

Jan 11 2022, 8:54 PM
mollekopf updated the diff for D2984: Proxy authorization for irony/syncroton.

Addressed comments

Jan 11 2022, 8:54 PM
mollekopf added inline comments to D2984: Proxy authorization for irony/syncroton.
Jan 11 2022, 8:53 PM
mollekopf accepted D3196: StatusPropertyTrait, and some more code de-duplication.
Jan 11 2022, 7:55 PM
mollekopf added a comment to D3196: StatusPropertyTrait, and some more code de-duplication.

Since traits can't define constants yet, one possible improvement would be to define interfaces, and use them together with trait(s). And we could unify the constant values to be the same for all objects at some point too. Still, User has STATUS_DEGRADED, Domain has STATUS_CONFIRMED, etc. So, for example:

interface StatusSuspendedInterface {
    const STATUS_SUSPENDED = 4;
    function isSuspended();
    function suspend();
    function unsuspend();
}

For now I prefer to not define interfaces and use my simple trait with the common status functionality.

Jan 11 2022, 7:54 PM
mollekopf committed rK9f64703aff04: utils: activesynccli, kolabendpointtester, generatemail (authored by mollekopf).
utils: activesynccli, kolabendpointtester, generatemail
Jan 11 2022, 7:47 PM
mollekopf closed D3211: utils: activesynccli, kolabendpointtester, generatemail.
Jan 11 2022, 7:47 PM
machniak accepted D3211: utils: activesynccli, kolabendpointtester, generatemail.
Jan 11 2022, 9:57 AM
mollekopf accepted D3250: [Python 3] Use new exception syntax, part 2.
Jan 11 2022, 8:31 AM

Jan 10 2022

sicherha requested review of D3250: [Python 3] Use new exception syntax, part 2.
Jan 10 2022, 10:03 PM
sicherha committed rPcfdb3e4f7f15: [Python 3] Use .items() instead of .iteritems() (authored by sicherha).
[Python 3] Use .items() instead of .iteritems()
Jan 10 2022, 8:51 PM
sicherha closed D3244: [Python 3] Use .items() instead of .iteritems().
Jan 10 2022, 8:51 PM
sicherha committed rP9a5f92139d3f: [Python 3] Get rid of .has_key() (authored by sicherha).
[Python 3] Get rid of .has_key()
Jan 10 2022, 8:50 PM
sicherha closed D3241: [Python 3] Get rid of .has_key().
Jan 10 2022, 8:50 PM
sicherha committed rPc3b9d5557161: [Python 3] Remove unnecessary occurrences of .keys() (authored by sicherha).
[Python 3] Remove unnecessary occurrences of .keys()
Jan 10 2022, 8:48 PM
sicherha closed D3235: [Python 3] Remove unnecessary occurrences of .keys().
Jan 10 2022, 8:48 PM
sicherha closed D3232: [Python 3] Use new exception syntax.
Jan 10 2022, 8:46 PM
sicherha committed rP991255eaa314: [Python 3] Use new exception syntax (authored by sicherha).
[Python 3] Use new exception syntax
Jan 10 2022, 8:46 PM
sicherha committed rPd0579b7e5da3: [Python 3] Use print() as function instead of statement (authored by sicherha).
[Python 3] Use print() as function instead of statement
Jan 10 2022, 8:42 PM
sicherha closed D3229: [Python 3] Use print() as function instead of statement.
Jan 10 2022, 8:42 PM
sicherha committed rP7750671314e6: [Python 3] Use 0o prefix for octal numbers (authored by sicherha).
[Python 3] Use 0o prefix for octal numbers
Jan 10 2022, 8:41 PM
sicherha closed D3226: [Python 3] Use 0o prefix for octal numbers.
Jan 10 2022, 8:41 PM
sicherha committed rP25766ccf2710: [Python 3] Avoid use of 0 prefix for decimal literals (authored by sicherha).
[Python 3] Avoid use of 0 prefix for decimal literals
Jan 10 2022, 8:38 PM
sicherha closed D3223: [Python 3] Avoid use of 0 prefix for decimal literals.
Jan 10 2022, 8:38 PM
mollekopf added a comment to T6805: Port pykolab to Python 3.

Apparently I need to be added to the PyKolab Developers group to be able to land changes.

Jan 10 2022, 7:12 PM · Architecture & Design
mollekopf added a member for PyKolab Developers: sicherha.
Jan 10 2022, 7:12 PM
sicherha added a comment to T6805: Port pykolab to Python 3.

Apparently I need to be added to the PyKolab Developers group to be able to land changes.

Jan 10 2022, 6:18 PM · Architecture & Design
machniak committed rS5838cfd4a733: Require zend-json (authored by machniak).
Require zend-json
Jan 10 2022, 4:50 PM
mollekopf added inline comments to D3211: utils: activesynccli, kolabendpointtester, generatemail.
Jan 10 2022, 12:23 PM
mollekopf updated the diff for D3211: utils: activesynccli, kolabendpointtester, generatemail.

Script cleanup

Jan 10 2022, 12:22 PM
mollekopf committed rK7b5c09f0a54f: Improve 09-enable-debugging (authored by mollekopf).
Improve 09-enable-debugging
Jan 10 2022, 12:13 PM
mollekopf committed rK65ff4d17e8f1: set the new invitation policy (authored by mollekopf).
set the new invitation policy
Jan 10 2022, 12:13 PM
mollekopf committed rKef3b5ed9cbf4: Configure the new webmail_url (authored by mollekopf).
Configure the new webmail_url
Jan 10 2022, 12:13 PM
mollekopf committed rKdff0dad77ec1: utils: activesynccli, kolabendpointtester, generatemail (authored by mollekopf).
utils: activesynccli, kolabendpointtester, generatemail
Jan 10 2022, 12:13 PM
mollekopf committed rKa038ec315193: Kolab development environment (authored by mollekopf).
Kolab development environment
Jan 10 2022, 12:13 PM
mollekopf committed rKc1c8c229ef34: "production" meet server deployment (authored by mollekopf).
"production" meet server deployment
Jan 10 2022, 12:13 PM
mollekopf committed rKa6772ff4d133: Enabled the kolab invitation calendars (authored by mollekopf).
Enabled the kolab invitation calendars
Jan 10 2022, 12:13 PM
mollekopf committed rK992d38b93db9: Resourcemanagement patches (authored by mollekopf).
Resourcemanagement patches
Jan 10 2022, 12:13 PM
mollekopf committed rK513cada1af44: Set the new invitation policy (authored by mollekopf).
Set the new invitation policy
Jan 10 2022, 12:13 PM
mollekopf added a reverting change for rK0f46d2ae62ed: Use https for the roundcube backend: rK84dec6491252: Added a patching mechanism.
Jan 10 2022, 12:13 PM
mollekopf committed rK84dec6491252: Added a patching mechanism (authored by mollekopf).
Added a patching mechanism
Jan 10 2022, 12:13 PM
mollekopf committed rK2282652967b0: Added cache to .gitignore (authored by mollekopf).
Added cache to .gitignore
Jan 10 2022, 12:13 PM
mollekopf committed rK323faa8f22a6: CompanionApp WIP (authored by mollekopf).
CompanionApp WIP
Jan 10 2022, 12:13 PM
mollekopf committed rK61d8a29389dc: Healthchecks (authored by mollekopf).
Healthchecks
Jan 10 2022, 12:13 PM
mollekopf committed rK4681da7ce206: Make kolab deployment ready to install on a linode (authored by mollekopf).
Make kolab deployment ready to install on a linode
Jan 10 2022, 12:13 PM
mollekopf committed rK4070f33fc302: Proxy authorization for irony/syncroton (authored by mollekopf).
Proxy authorization for irony/syncroton
Jan 10 2022, 12:13 PM
mollekopf committed rKf3d34412c14a: bin/quickstart.sh enhancements (authored by mollekopf).
bin/quickstart.sh enhancements
Jan 10 2022, 12:13 PM
mollekopf committed rK7e00d6e8997f: Mediasoup based Kolab Meet (authored by mollekopf).
Mediasoup based Kolab Meet
Jan 10 2022, 12:13 PM
mollekopf committed rKedcd78120cf2: Use password command (authored by mollekopf).
Use password command
Jan 10 2022, 12:13 PM
mollekopf committed rKe2c9a06fbc86: My pdf output is only 2696 bytes long (authored by mollekopf).
My pdf output is only 2696 bytes long
Jan 10 2022, 12:13 PM
machniak committed rKa9ad1196af9c: Kolab3 migration tool (authored by machniak).
Kolab3 migration tool
Jan 10 2022, 11:31 AM
machniak closed D3184: Kolab3 migration tool.
Jan 10 2022, 11:31 AM
machniak committed rKed984b2e359d: Split client javascript code into core+unauthenticated and authenticated, the… (authored by machniak).
Split client javascript code into core+unauthenticated and authenticated, the…
Jan 10 2022, 11:28 AM
machniak closed D3008: Split client javascript code into core+unauthenticated and authenticated, the same for admin/reseller.
Jan 10 2022, 11:28 AM
machniak updated the diff for D3184: Kolab3 migration tool.
  • Drop temp table
Jan 10 2022, 11:27 AM
mollekopf accepted D3008: Split client javascript code into core+unauthenticated and authenticated, the same for admin/reseller.
Jan 10 2022, 11:19 AM
mollekopf added a comment to D3008: Split client javascript code into core+unauthenticated and authenticated, the same for admin/reseller.

Looks reasonable, maybe a webpackPrefetch: true could make sense to enable prefetching (might be enabled by default anyways though).

Jan 10 2022, 11:19 AM
machniak added a comment to D3196: StatusPropertyTrait, and some more code de-duplication.

Since traits can't define constants yet, one possible improvement would be to define interfaces, and use them together with trait(s). And we could unify the constant values to be the same for all objects at some point too. Still, User has STATUS_DEGRADED, Domain has STATUS_CONFIRMED, etc. So, for example:

interface StatusSuspendedInterface {
    const STATUS_SUSPENDED = 4;
    function isSuspended();
    function suspend();
    function unsuspend();
}

For now I prefer to not define interfaces and use my simple trait with the common status functionality.

Jan 10 2022, 11:12 AM