In first, I wish you a Happy New Year!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 13 2022
Jan 12 2022
I'd prefer .arc folder instead of phabricator.
Rebased
Rebasing
- Updating D3202: Added a patching mechanism
Fixup
Jan 11 2022
phpcs fixes
Just like what we have for phpstan.
Fixed some phpstan complaints
Addressed comments
In D3196#38563, @machniak wrote:Since traits can't define constants yet, one possible improvement would be to define interfaces, and use them together with trait(s). And we could unify the constant values to be the same for all objects at some point too. Still, User has STATUS_DEGRADED, Domain has STATUS_CONFIRMED, etc. So, for example:
interface StatusSuspendedInterface { const STATUS_SUSPENDED = 4; function isSuspended(); function suspend(); function unsuspend(); }For now I prefer to not define interfaces and use my simple trait with the common status functionality.
Jan 10 2022
In T6805#94630, @sicherha wrote:Apparently I need to be added to the PyKolab Developers group to be able to land changes.
Apparently I need to be added to the PyKolab Developers group to be able to land changes.
Script cleanup
Looks reasonable, maybe a webpackPrefetch: true could make sense to enable prefetching (might be enabled by default anyways though).
Since traits can't define constants yet, one possible improvement would be to define interfaces, and use them together with trait(s). And we could unify the constant values to be the same for all objects at some point too. Still, User has STATUS_DEGRADED, Domain has STATUS_CONFIRMED, etc. So, for example:
interface StatusSuspendedInterface { const STATUS_SUSPENDED = 4; function isSuspended(); function suspend(); function unsuspend(); }
For now I prefer to not define interfaces and use my simple trait with the common status functionality.