Please, also fix this:

FILE: ...home/alec/repos/kolab/src/tests/Feature/Stories/GreylistTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 434 | ERROR | [x] The closing brace for the class must go on the
     |       |     next line after the body

Reuse the existing function to query for the connection

Avoid the unnecessary insert + update

I found one problem with this approach. The handlers registered by these traits are executed before observer's event handlers. I.e. we generate uuid before we do 'creating' pre-checks. For example EntitlementObserver. I think it makes sense to keep pre-checks in the observer, and do "simple" stuff via traits, but the order should be reversed so observers run first. Well, at least for these cases at hand it would be a proper way.

Rebased on uuidtraitpatch

Renamed traits

Use the trait boot method so we can have multiple traits with boot methods

Use the trait boot method so we can have multiple traits with boot methods

Use the configured id instead of assuming a name

In D2815#33931, @mollekopf wrote:

Looks good to me. We should probably also create a policycontrollertest, to test if this actually works, but that doesn't need to be in this diff.

Looks good to me. We should probably also create a policycontrollertest, to test if this actually works, but that doesn't need to be in this diff.

• Remove redundant ->limit(1)

• Move greylisting setting back to user_settings, cleanup

• Merge branch 'master' into dev/status-degraded
• Add some French localization

• Performance optimizations

• Small perf. improvement, skip redundant query

I think I would prefer UuidIntKeyTrait and UuidStrKeyTrait. Other than that it looks good.