Page MenuHomePhorge
Feed All Stories

Apr 17 2019

mollekopf added reviewers for D755: Support shortlogins via the username_domain configuration option.: iRony Developers, machniak, vanmeeuwen.
Apr 17 2019, 12:19 PM
mollekopf requested review of D755: Support shortlogins via the username_domain configuration option..
Apr 17 2019, 12:17 PM
machniak committed rRPKce24ec1bdd78: Fix bug where newly added element in tag cloud was not clickable (in… (authored by machniak).
Fix bug where newly added element in tag cloud was not clickable (in…
Apr 17 2019, 11:59 AM
machniak committed rRPK09e8dcce9880: Fix regression where removing tags from one message would remove tag badge from… (authored by machniak).
Fix regression where removing tags from one message would remove tag badge from…
Apr 17 2019, 11:53 AM

Apr 16 2019

machniak committed rS88ab52e07d43: Fix logging SecondsLeft value (in case of a ping loop break) (authored by machniak).
Fix logging SecondsLeft value (in case of a ping loop break)
Apr 16 2019, 1:24 PM
machniak committed rRPK12ce9fd4c799: Ignore address_book_type setting when checking for global addressbooks (authored by machniak).
Ignore address_book_type setting when checking for global addressbooks
Apr 16 2019, 12:51 PM

Apr 15 2019

vanmeeuwen committed rQAec2c0bd312a5: Initial commit (authored by vanmeeuwen).
Initial commit
Apr 15 2019, 8:17 PM
vanmeeuwen committed rRPK4ad016bce468: Bump versions to 3.4.4 (authored by vanmeeuwen).
Bump versions to 3.4.4
Apr 15 2019, 11:05 AM

Apr 13 2019

dhoffend added a comment to D749: return empty folder list if backend is disabled.

In my case: the kolab was used as backend, the backend storage was disabled and an additional pre-defined source to a seafile server was configured. In the kolab_files folder list the Imap Files Folder always showed up, but couldn't be selected because the backend storage was disabled. This was confusing. When deleted it always got recreated, ether through the autocreate_folders section or kolab_folders plugin.

Apr 13 2019, 7:09 PM
dhoffend requested review of D749: return empty folder list if backend is disabled.
Apr 13 2019, 7:04 PM
machniak added a comment to T5339: Seafile as sole storage driver doesn't load subfolders.

I think we'd need a change around https://git.kolab.org/diffusion/C/browse/master/lib/api/common.php$237, but I didn't think about it yet.

Apr 13 2019, 9:54 AM · Roundcube Kolab Plugins , Bug Reports
dhoffend updated the summary of D743: replaced sole seafile setup with pre-defined sources.
Apr 13 2019, 3:14 AM
dhoffend requested review of D743: replaced sole seafile setup with pre-defined sources.
Apr 13 2019, 3:12 AM
dhoffend added a comment to T5339: Seafile as sole storage driver doesn't load subfolders.

I did some debugging in the seafile_file_storage class.

Apr 13 2019, 12:24 AM · Roundcube Kolab Plugins , Bug Reports

Apr 12 2019

adomaitis updated the diff for D732: This is first attempt to add a AD schema import / load to kolab setup tools. The idea is that when setup-kolab is run with --with-ad it should ask questions about where the AD server is and how to connect to it. Then it should compile a AD schema....
  • fix error message by showing which template file was not found
  • Move find_template function to utils as there is a plan to use it elsewhere.
  • Changes to setup-kolab mta utility to support AD. Postfix LDAP lookup tables are now created using Jinja2 templates.
  • Log clamav updates to /var/log/freshclam.log file. Don't want to create a dir.
  • Jinja2 templates for Postfix and Amavisd configuration.
Apr 12 2019, 1:07 PM
machniak committed rP5269d27803ef: Be more forgiving on dummy entries in DTSTAMP,LAST-MODIFIED and CREATED… (authored by machniak).
Be more forgiving on dummy entries in DTSTAMP,LAST-MODIFIED and CREATED…
Apr 12 2019, 12:38 PM
machniak committed rP23e2c4637f55: Be more forgiving on dummy entries in DTSTAMP,LAST-MODIFIED and CREATED… (authored by machniak).
Be more forgiving on dummy entries in DTSTAMP,LAST-MODIFIED and CREATED…
Apr 12 2019, 12:37 PM
machniak committed rP3a92133e7e18: Fix event|todo_from_ical() exception: AttributeError("'NoneType' object has no… (authored by machniak).
Fix event|todo_from_ical() exception: AttributeError("'NoneType' object has no…
Apr 12 2019, 10:44 AM
machniak added a comment to T5339: Seafile as sole storage driver doesn't load subfolders.
$config['fileapi_sources'] = array(
    'Seafile' => array(
        'driver' => 'seafile',
        'host'   => 'seacloud.cc',
        // when username is set to '%u' current user name and password
        // will be used to authenticate to this storage source
        'username' => '%u',
    )
);
// You can also add
$config['fileapi_backend_storage_disabled'] = true;
Apr 12 2019, 10:02 AM · Roundcube Kolab Plugins , Bug Reports
dhoffend added a comment to T5339: Seafile as sole storage driver doesn't load subfolders.

Okay I’ll take a look on it later. I guess it’s this part:
https://git.kolab.org/diffusion/C/browse/master/lib/drivers/seafile/seafile_file_storage.php$918

Apr 12 2019, 9:49 AM · Roundcube Kolab Plugins , Bug Reports
machniak added a comment to T5339: Seafile as sole storage driver doesn't load subfolders.

That scenario is not supported because you can't store config and you can't use cache without kolab backend. You could probably live without these in some setups, so yes in theory it should work. There must be a bug somewhere.

Apr 12 2019, 9:11 AM · Roundcube Kolab Plugins , Bug Reports
dhoffend added a comment to T5339: Seafile as sole storage driver doesn't load subfolders.

Hmmm But in theory it could work. I get the list of repositories. Chwala works correctly and lists all folders. Just kolab_files doesn’t get over it and doesn’t request the subfolders of each repo which is presented. BTW the files on the roots of each repo are shown as well.

Apr 12 2019, 9:03 AM · Roundcube Kolab Plugins , Bug Reports
machniak added a comment to T5339: Seafile as sole storage driver doesn't load subfolders.

... and we should throw an error when fileapi_backend != 'kolab'.

Apr 12 2019, 8:57 AM · Roundcube Kolab Plugins , Bug Reports
machniak added a comment to T5339: Seafile as sole storage driver doesn't load subfolders.

I think we should finally remove that section from documentation. It is not supported scenario, I think it is not even supposed to work. There's a comment in sample config:

// Main files source, backend driver which handles
// authentication and configuration of Chwala
// Note: Currently only 'kolab' is supported
$config['fileapi_backend'] = 'kolab';
Apr 12 2019, 8:56 AM · Roundcube Kolab Plugins , Bug Reports
dhoffend added a comment to T5339: Seafile as sole storage driver doesn't load subfolders.

Basically exactly like described in the howto: https://docs.kolab.org/howtos/use-seafile-with-chwala.html?highlight=seafile#using-seafile-as-an-exclusive-storage-mechanism

Apr 12 2019, 8:53 AM · Roundcube Kolab Plugins , Bug Reports
machniak added a comment to T5339: Seafile as sole storage driver doesn't load subfolders.

Yes, kolab_files uses now different (semi-recurrent) logic to fetch folders hierarchy. How exactly did you configure chwala with seafile?

Apr 12 2019, 7:43 AM · Roundcube Kolab Plugins , Bug Reports

Apr 11 2019

dhoffend updated the task description for T5339: Seafile as sole storage driver doesn't load subfolders.
Apr 11 2019, 11:41 PM · Roundcube Kolab Plugins , Bug Reports
dhoffend created T5339: Seafile as sole storage driver doesn't load subfolders.
Apr 11 2019, 11:39 PM · Roundcube Kolab Plugins , Bug Reports
vanmeeuwen committed rRPKf2e340e67fc5: Bump version numbers (authored by vanmeeuwen).
Bump version numbers
Apr 11 2019, 4:34 PM
vanmeeuwen committed rPc5e12dc1cf8d: Include /etc/roundcubemail/kolab_syncroton.inc.php (authored by vanmeeuwen).
Include /etc/roundcubemail/kolab_syncroton.inc.php
Apr 11 2019, 2:53 PM
bobalo created T5333: Roundcube calendar issues.
Apr 11 2019, 2:04 PM · Roundcube Kolab Plugins , Bug Reports
vanmeeuwen committed rSd712e2291e35: List the default plugins loaded as well (authored by vanmeeuwen).
List the default plugins loaded as well
Apr 11 2019, 2:00 PM
vanmeeuwen committed rS595d1cf6a8b6: Set defaults most representative of the user's expectations (authored by vanmeeuwen).
Set defaults most representative of the user's expectations
Apr 11 2019, 1:59 PM
vanmeeuwen committed rIea645099ea39: Avoid refering to kolab_auth if it isn't actually there (authored by vanmeeuwen).
Avoid refering to kolab_auth if it isn't actually there
Apr 11 2019, 12:48 PM
ttf4141 updated ttf4141.
Apr 11 2019, 6:45 AM

Apr 10 2019

machniak committed rACe612b2461219: Merge branch 'arcpatch-D737' (authored by machniak).
Merge branch 'arcpatch-D737'
Apr 10 2019, 12:16 PM
machniak committed rACbbd4949ef530: fix return value of init_ldap() (authored by dhoffend).
fix return value of init_ldap()
Apr 10 2019, 12:16 PM
machniak closed D737: fix return value of init_ldap().
Apr 10 2019, 12:16 PM
machniak committed rACced200722283: Add .arcconfig (authored by machniak).
Add .arcconfig
Apr 10 2019, 12:16 PM
machniak accepted D737: fix return value of init_ldap().

That's a bug introduced by e544905221b and the fix makes sense.

Apr 10 2019, 8:26 AM

Apr 9 2019

dhoffend requested review of D737: fix return value of init_ldap().
Apr 9 2019, 11:51 PM
machniak committed rPNLf6c169d2f841: Fix PHP Warning: Use of undefined constant MEMCACHE_COMPRESSED... on PHP 7.3… (authored by machniak).
Fix PHP Warning: Use of undefined constant MEMCACHE_COMPRESSED... on PHP 7.3…
Apr 9 2019, 11:36 AM
machniak committed rPNL0b06e6b94a53: Optimize _string2hex() (authored by machniak).
Optimize _string2hex()
Apr 9 2019, 11:12 AM
machniak committed rPNL7c11457365d5: Add some constants (authored by machniak).
Add some constants
Apr 9 2019, 10:53 AM
machniak committed rPNL5afbfd60715a: More unified debug messages around ldap_search() (authored by machniak).
More unified debug messages around ldap_search()
Apr 9 2019, 10:53 AM
machniak committed rPNLbfeed40b5ec3: Use config_root_dn => cn=config as a default (authored by machniak).
Use config_root_dn => cn=config as a default
Apr 9 2019, 10:32 AM

Apr 8 2019

machniak committed rRPKac60e5936640: We accept iTip replies with older SEQUENCE but no significant changes… (authored by machniak).
We accept iTip replies with older SEQUENCE but no significant changes…
Apr 8 2019, 12:32 PM
machniak committed rRPKb5bde340c239: Get rid of jQuery-UI button use (authored by machniak).
Get rid of jQuery-UI button use
Apr 8 2019, 11:21 AM
machniak committed rRPK7ed760cda0fa: Fix button selectors (.ui-button -> button) (authored by machniak).
Fix button selectors (.ui-button -> button)
Apr 8 2019, 11:04 AM
machniak committed rRPKf31c329ca78f: Fix button selectors (.ui-button -> button) (authored by machniak).
Fix button selectors (.ui-button -> button)
Apr 8 2019, 10:37 AM

Apr 6 2019

machniak added a comment to T2720: Remove "Save sent message in" from mail composer.

@bohlender, would you make a summary in English for me, or should I just ignore all comments?

Apr 6 2019, 8:56 AM · UX Seminar WS17

Apr 5 2019

bohlender assigned T2720: Remove "Save sent message in" from mail composer to machniak.
Apr 5 2019, 4:17 PM · UX Seminar WS17
bohlender renamed T2720: Remove "Save sent message in" from mail composer from Doppelte Speichern-Funktion beim Mail Schreiben to Remove "Save sent message in" from mail composer.
Apr 5 2019, 4:16 PM · UX Seminar WS17

Apr 4 2019

smiler2505 updated the task description for T5327: Apostrophe in employee name causes LDAP crash.
Apr 4 2019, 6:19 PM · PyKolab, Bug Reports
smiler2505 added a comment to T5327: Apostrophe in employee name causes LDAP crash.

Apologies that this has taken some time to post, I found the solution earlier today but was investigating other issues too. The patch is to add, on line 133:

user_attrs['surname'] = user_attrs['surname'].replace(r"'", r"\'")
Apr 4 2019, 6:14 PM · PyKolab, Bug Reports
smiler2505 updated the task description for T5327: Apostrophe in employee name causes LDAP crash.
Apr 4 2019, 3:01 PM · PyKolab, Bug Reports
smiler2505 lowered the priority of T5327: Apostrophe in employee name causes LDAP crash from Unbreak Now! to Needs Triage.

Moving priority back to needs triage, I had caused a second fault during my investigation with a stray vim command. The above code alters the message to:

Apr 4 2019, 2:46 PM · PyKolab, Bug Reports
smiler2505 renamed T5327: Apostrophe in employee name causes LDAP crash from Apostrophe in employee name causes fail in slapd to Apostrophe in employee name causes LDAP crash.
Apr 4 2019, 2:08 PM · PyKolab, Bug Reports
smiler2505 raised the priority of T5327: Apostrophe in employee name causes LDAP crash from Needs Triage to Unbreak Now!.

Ignore this post, I am keeping it here as it was a clue to the final solution:

Apr 4 2019, 2:08 PM · PyKolab, Bug Reports
bohlender reassigned T4983: When selecting a time you can't see them all from isabel.pacheco to machniak.
Apr 4 2019, 8:08 AM · UX Seminar WS17
smiler2505 created T5327: Apostrophe in employee name causes LDAP crash.
Apr 4 2019, 6:16 AM · PyKolab, Bug Reports

Apr 3 2019

Liutauras Adomaitis <adomaitis@kolabsystems.com> committed rPb636df531742: Changes required for pykolab to work with AD (authored by Liutauras Adomaitis <adomaitis@kolabsystems.com>).
Changes required for pykolab to work with AD
Apr 3 2019, 4:08 PM
Diffusion closed D720: Changes required for pykolab to work with AD.
Apr 3 2019, 4:08 PM · PyKolab
adomaitis updated the diff for D732: This is first attempt to add a AD schema import / load to kolab setup tools. The idea is that when setup-kolab is run with --with-ad it should ask questions about where the AD server is and how to connect to it. Then it should compile a AD schema....
  • Don't need this log.
  • Fail immediatly if connection to LDAP server could not be made
  • Get supported ldap controls and match with what is supported by pykolab
Apr 3 2019, 4:05 PM
machniak committed rRPKa0454e8080db: kolab_sso: Add oauth2 and seas drivers (Bifrost#T194908) (authored by machniak).
kolab_sso: Add oauth2 and seas drivers (Bifrost#T194908)
Apr 3 2019, 12:56 PM
machniak accepted D720: Changes required for pykolab to work with AD.
Apr 3 2019, 8:10 AM · PyKolab
adomaitis updated the diff for D720: Changes required for pykolab to work with AD.
  • Use python UUID to convert binary objectGUID to string. It doesn't look like value of uniqueid returned by from cache is used anywhere (needs to double check), so only forward conversion is needed.
Apr 3 2019, 7:50 AM · PyKolab

Apr 2 2019

machniak added inline comments to D720: Changes required for pykolab to work with AD.
Apr 2 2019, 3:42 PM · PyKolab
machniak requested changes to D720: Changes required for pykolab to work with AD.
Apr 2 2019, 3:27 PM · PyKolab
machniak committed rPNL2b73ea21f8de: Fix effective rights on PHP 7.3 (authored by machniak).
Fix effective rights on PHP 7.3
Apr 2 2019, 1:02 PM
machniak committed rRPKc64a272df384: Pass attributes list to get_entry() (authored by machniak).
Pass attributes list to get_entry()
Apr 2 2019, 12:40 PM
machniak committed rPNLc8cbff0969f5: On PHP 7.3. use ldap_read() to get effective rights (authored by machniak).
On PHP 7.3. use ldap_read() to get effective rights
Apr 2 2019, 12:35 PM

Apr 1 2019

adomaitis updated the diff for D720: Changes required for pykolab to work with AD.
  • Use python UUID to convert binary objectGUID to string. It doesn't look like value of uniqueid returned by from cache is used anywhere (needs to double check), so only forward conversion is needed.
  • Also do not strip anything from bytestring attributes (objectGUID) because after stripping conversion to UUID string is not possible.
Apr 1 2019, 1:14 PM · PyKolab
machniak committed rRPK3c9caa4ce147: Elastic: Fix small regression in document editor toolbar (authored by machniak).
Elastic: Fix small regression in document editor toolbar
Apr 1 2019, 10:29 AM

Mar 31 2019

quitcomplaining closed T5276: DATE field not populating in Roundcube email view as Resolved.

Updated /etc/php.ini and moved the "date.timezone = America/New_York" setting to it's correct position under MODULE settings > "Date > ; http://php.net/date.timezone".
It had been entered under MODULE settings > Date > "; http://php.net/date.sunset-zenith" erroneously.
After saving the edit, I restarted, httpd and timestamps started showing up properly.

Mar 31 2019, 5:55 AM · Bug Reports
quitcomplaining added a comment to T5276: DATE field not populating in Roundcube email view.

vanmeeuwen. - Time stamp is there in source and timezone is correct: Mon, 25 Mar 2019 23:53:00 -0400

Mar 31 2019, 5:49 AM · Bug Reports

Mar 30 2019

daerimin created T5321: Please update kolab_sync_data.php to read additional device signatures from an external file, if that file is present..
Mar 30 2019, 12:03 PM · Syncroton

Mar 28 2019

machniak committed rRPKa2cbb0855eef: Don't send iTip requests when an attendee moves/resizes an event… (authored by machniak).
Don't send iTip requests when an attendee moves/resizes an event…
Mar 28 2019, 4:35 PM
machniak committed rRPK54851bbc6bcb: Don't send iTip requests when an attendee moves/resizes an event… (authored by machniak).
Don't send iTip requests when an attendee moves/resizes an event…
Mar 28 2019, 4:33 PM
adomaitis updated the diff for D732: This is first attempt to add a AD schema import / load to kolab setup tools. The idea is that when setup-kolab is run with --with-ad it should ask questions about where the AD server is and how to connect to it. Then it should compile a AD schema....

Kind of finished version of Pykolab way of Active Directory setup:

  • For AD LDAP modification I decided to use Jinja2 templates, which are in templates folder. Several reasons for that:
    • Long texts of changes to be performed in python code does not look nice, especially when AD Kolab schema needs to be added.
    • Ansible uses Jinja2 for templates, so templates used by setup_ldap.py can be reused with Ansible.
    • It becomes easier to load additional data to LDAP (like data to for testing purposes) or setup OpenLDAP for use with Kolab.

Using Jinja2 creates python-jinja2 package dependency
TODO - Need to decide where Jinja2 templates should be installed. Currently /etc/kolab/templates/, /usr/share/kolab/templates/ and os.path.join(__file__, '..', '..', '..', 'share', 'templates' paths are used to find templates.

Mar 28 2019, 10:45 AM
vanmeeuwen lowered the priority of T3775: Wallace is not processing invitations for members of a group (edited) from 60 to Normal.
Mar 28 2019, 8:03 AM · PyKolab, Bug Reports
vanmeeuwen added a comment to T3775: Wallace is not processing invitations for members of a group (edited).

What do you expect to happen when an invitation is created, and 'group@example.org' is invited?

Mar 28 2019, 8:03 AM · PyKolab, Bug Reports
vanmeeuwen closed T5288: Hot Filling PET Bottle Fully Automatic Blow Moulding Machine factory as Invalid.
Mar 28 2019, 7:33 AM
vanmeeuwen closed T5291: Stainless Vacuum Tumbler Made in China as Invalid.
Mar 28 2019, 7:33 AM
vanmeeuwen closed T5294: Medium Voltage Composite Insulators as Invalid.
Mar 28 2019, 7:33 AM
vanmeeuwen closed T5300: Customized Special Fastener as Invalid.
Mar 28 2019, 7:33 AM
vanmeeuwen closed T5297: Rubber Puzzle Mat as Invalid.
Mar 28 2019, 7:33 AM
vanmeeuwen closed T5303: Atmel Cortex-A5 Evaluation Board manufacturers as Invalid.
Mar 28 2019, 7:33 AM
vanmeeuwen closed T5306: China Aluminum FRP Honeycomb Sandwich Panel factory as Invalid.
Mar 28 2019, 7:33 AM
vanmeeuwen closed T5309: Customized 3310 3g Feature Phone as Invalid.
Mar 28 2019, 7:33 AM
vanmeeuwen closed T5312: China UL DLC LED Area Light as Invalid.
Mar 28 2019, 7:33 AM
vanmeeuwen closed T5315: Chain Fall Hoist for sale as Invalid.
Mar 28 2019, 7:33 AM
kslfkg2 created T5315: Chain Fall Hoist for sale.
Mar 28 2019, 6:51 AM
kslfkg2 created T5312: China UL DLC LED Area Light.
Mar 28 2019, 6:50 AM
kslfkg2 created T5309: Customized 3310 3g Feature Phone.
Mar 28 2019, 6:50 AM
kslfkg2 created T5306: China Aluminum FRP Honeycomb Sandwich Panel factory.
Mar 28 2019, 6:50 AM
kslfkg2 created T5303: Atmel Cortex-A5 Evaluation Board manufacturers.
Mar 28 2019, 6:50 AM
kslfkg2 created T5300: Customized Special Fastener.
Mar 28 2019, 6:49 AM
kslfkg2 created T5297: Rubber Puzzle Mat.
Mar 28 2019, 6:49 AM
kslfkg2 created T5294: Medium Voltage Composite Insulators.
Mar 28 2019, 6:48 AM