Page MenuHomePhorge
Differential D98

enable tests custom directories
ClosedPublic
Actions

Authored by johnyb on Mar 10 2016, 10:37 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, May 26, 5:23 PM
Unknown Object (File)
Tue, May 21, 8:23 PM
Unknown Object (File)
Tue, May 21, 9:45 AM
Unknown Object (File)
Mon, May 20, 5:38 AM
Unknown Object (File)
Sun, May 19, 10:43 AM
Unknown Object (File)
Sun, May 19, 10:16 AM
Unknown Object (File)
Fri, May 17, 10:02 PM
Unknown Object (File)
Wed, May 15, 5:28 PM
View All Files
Subscribers
None

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rG8121e2066dc3: enable tests custom directories
rG6241707b0eb1: enable tests custom directories
Summary

Hard-coded directory made it impossible to run the tests.

Test Plan
  1. build the project
  2. run make test

Expected results: tests run
Actual result without patch: some error message
Actual result with patch applied: tests run, 2 failing - unrelated, though

Diff Detail

Repository
rG guam
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

johnyb updated this revision to Diff 203.Mar 10 2016, 10:37 PM
johnyb retitled this revision from to enable tests, again.
johnyb updated this object.
johnyb edited the test plan for this revision. (Show Details)
johnyb added a reviewer: Restricted Project.
johnyb set the repository for this revision to rG guam.
johnyb added a project: Guam.
johnyb retitled this revision from enable tests, again to enable tests custom directories.Mar 10 2016, 10:40 PM
Closed by commit rG6241707b0eb1: enable tests custom directories (authored by • seigo, committed by • seigo). · Explain WhyMay 9 2016, 10:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
3 lines
2 lines

Diff 338

View Options

.gitignore

Loading...
View Options

Makefile

Loading...
View Options

cover.spec

Loading...
View Options

cover.spec.in

Loading...