Page MenuHomePhorge

fix return value of init_ldap()
ClosedPublic

Authored by dhoffend on Apr 9 2019, 11:51 PM.
Tags
None
Referenced Files
F11584164: D737.id1685.diff
Thu, Mar 28, 6:48 AM
Unknown Object (File)
Sun, Mar 24, 11:50 AM
Unknown Object (File)
Sat, Mar 2, 3:14 AM
Unknown Object (File)
Feb 19 2024, 12:42 PM
Unknown Object (File)
Feb 9 2024, 4:32 PM
Unknown Object (File)
Feb 8 2024, 1:06 PM
Unknown Object (File)
Feb 7 2024, 10:35 AM
Unknown Object (File)
Jan 29 2024, 1:18 PM
Subscribers
None

Details

Summary

init_ldap doesn't return true on success

autoconf doesn't lookup the username in ldap because init_ldap() always returns
null, but get_user() expects a non-false response.

Diff Detail

Repository
rAC autoconf
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23558
Build 9572: arc lint + arc unit

Event Timeline

dhoffend created this revision.

That's a bug introduced by e544905221b and the fix makes sense.

This revision is now accepted and ready to land.Apr 10 2019, 8:26 AM
This revision was automatically updated to reflect the committed changes.