Page MenuHomePhorge
Differential D3884

Space in cyrus imapfolder_path
ClosedPublic
Actions

Authored by ghane on Oct 4 2022, 1:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 6:35 PM
Unknown Object (File)
Wed, Apr 17, 9:48 AM
Unknown Object (File)
Tue, Apr 16, 3:46 PM
Unknown Object (File)
Sat, Apr 13, 6:32 AM
Unknown Object (File)
Fri, Apr 12, 4:42 PM
Unknown Object (File)
Sun, Apr 7, 10:10 AM
Unknown Object (File)
Sat, Apr 6, 1:17 AM
Unknown Object (File)
Wed, Apr 3, 1:12 PM
View All 54 Files
Subscribers
sicherha

Details

Reviewers
sicherha
mollekopf
Group Reviewers
PyKolab Developers
Commits
rPc255b3f728cb: Space in cyrus imapfolder_path
Summary

ensure_str needed see cyruslib handling
else string is compared with bytes and the imapfolder won't be verified

Test Plan

tested with dm DELETED* on buster with python 2.7 and 3.x

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ghane requested review of this revision.Oct 4 2022, 1:32 PM
ghane created this revision.
ghane added a parent revision: D3863: [Python 3] def ensure_binary / some ___prepare binary return fix.
sicherha subscribed.Oct 16 2022, 9:32 AM
sicherha added inline comments.
pykolab/imap/cyrus.py
572

In the original code, double quotes are added around the string; your change removes these quotes. Is there a particular reason for this?

sicherha mentioned this in D3863: [Python 3] def ensure_binary / some ___prepare binary return fix.Oct 16 2022, 9:38 AM
ghane added inline comments.Oct 22 2022, 12:11 PM
pykolab/imap/cyrus.py
572
[LIST "" ""b'DELETED/shared/group/Calendar/Personal Calendar/63344406@example.org'""] BAD: bUnexpected extra arguments to List

See doubled Quotes, which causes this Error

sicherha accepted this revision.Nov 6 2022, 2:23 PM
This revision is now accepted and ready to land.Nov 6 2022, 2:23 PM
ghane updated this revision to Diff 11384.Jan 2 2023, 12:35 PM

quote is set now in cyruslib.py line 564

new

def decode ... return quote(ensure_str(text))

old

return text

as quotes are now generally set to the mailbox path, so we don't need the if clause

ghane marked an inline comment as done.Jan 2 2023, 12:36 PM
ghane mentioned this in T6805: Port pykolab to Python 3.Jan 30 2023, 1:22 PM
mollekopf accepted this revision.Mar 5 2023, 8:15 PM
Closed by commit rPc255b3f728cb: Space in cyrus imapfolder_path (authored by mollekopf). · Explain WhyMar 7 2023, 9:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pykolab/
imap/
6 lines

Diff 11054

View Options

pykolab/imap/cyrus.py

Loading...