Page MenuHomePhorge
Differential D3029 Diff 9916 src/app/Http/Controllers/API/V4/CompanionAppsController.php

Changeset View

Standalone View

View Options

src/app/Http/Controllers/API/V4/CompanionAppsController.php

<?php <?php
namespace App\Http\Controllers\API\V4; namespace App\Http\Controllers\API\V4;
use App\Http\Controllers\Controller; use App\Http\Controllers\ResourceController;
use App\Utils;
use App\Tenant;
use Laravel\Passport\Token;
use Laravel\Passport\TokenRepository;
use Laravel\Passport\RefreshTokenRepository;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Support\Facades\Validator; use Illuminate\Support\Facades\Validator;
use BaconQrCode;
class CompanionAppsController extends Controller class CompanionAppsController extends ResourceController
{ {
/** /**
* Register a companion app. * Register a companion app.
* *
* @param \Illuminate\Http\Request $request The API request. * @param \Illuminate\Http\Request $request The API request.
* *
* @return \Illuminate\Http\JsonResponse The response * @return \Illuminate\Http\JsonResponse The response
*/ */
public function register(Request $request) public function register(Request $request)
{ {
$user = $this->guard()->user(); $user = $this->guard()->user();
$v = Validator::make( $v = Validator::make(
$request->all(), $request->all(),
[ [
'notificationToken' => 'required|min:4|max:512', 'notificationToken' => 'required|min:4|max:512',
'deviceId' => 'required|min:4|max:64', 'deviceId' => 'required|min:4|max:64',
'name' => 'required|max:512',
] ]
); );
if ($v->fails()) { if ($v->fails()) {
return response()->json(['status' => 'error', 'errors' => $v->errors()], 422); return response()->json(['status' => 'error', 'errors' => $v->errors()], 422);
} }
$notificationToken = $request->notificationToken; $notificationToken = $request->notificationToken;
$deviceId = $request->deviceId; $deviceId = $request->deviceId;
$name = $request->name;
\Log::info("Registering app. Notification token: {$notificationToken} Device id: {$deviceId}"); \Log::info("Registering app. Notification token: {$notificationToken} Device id: {$deviceId} Name: {$name}");
$app = \App\CompanionApp::where('device_id', $deviceId)->first(); $app = \App\CompanionApp::where('device_id', $deviceId)->first();
if (!$app) { if (!$app) {
$app = new \App\CompanionApp(); $app = new \App\CompanionApp();
$app->user_id = $user->id; $app->user_id = $user->id;
$app->device_id = $deviceId; $app->device_id = $deviceId;
$app->mfa_enabled = true; $app->mfa_enabled = true;
$app->name = $name;
} else { } else {
//FIXME this allows a user to probe for another users deviceId //FIXME this allows a user to probe for another users deviceId
if ($app->user_id != $user->id) { if ($app->user_id != $user->id) {
\Log::warning("User mismatch on device registration. Expected {$user->id} but found {$app->user_id}"); \Log::warning("User mismatch on device registration. Expected {$user->id} but found {$app->user_id}");
return $this->errorResponse(403); return $this->errorResponse(403);
} }
} }
$app->notification_token = $notificationToken; $app->notification_token = $notificationToken;
$app->save(); $app->save();
return response()->json(['status' => 'success']); return response()->json(['status' => 'success']);
} }
/**
* Generate a QR-code image for a string
*
* @param string $data data to encode
*
* @return string
*/
private static function generateQRCode($data)
{
$renderer_style = new BaconQrCode\Renderer\RendererStyle\RendererStyle(300, 1);
$renderer_image = new BaconQrCode\Renderer\Image\SvgImageBackEnd();
$renderer = new BaconQrCode\Renderer\ImageRenderer($renderer_style, $renderer_image);
$writer = new BaconQrCode\Writer($renderer);
return 'data:image/svg+xml;base64,' . base64_encode($writer->writeString($data));
}
/**
* Revoke all companion app devices.
*
* @return \Illuminate\Http\JsonResponse The response
*/
public function revokeAll()
{
$user = $this->guard()->user();
\App\CompanionApp::where('user_id', $user->id)->delete();
// Revoke all companion app tokens
$clientIdentifier = \App\Tenant::getConfig($user->tenant_id, 'auth.companion_app.client_id');
$tokens = Token::where('user_id', $user->id, 'client_id', $clientIdentifier);
$tokenRepository = app(TokenRepository::class);
$refreshTokenRepository = app(RefreshTokenRepository::class);
foreach ($tokens as $token) {
Lint: Argument of an invalid type Illuminate\Database\Eloquent\Builder<Laravel\Passport\Token> supplied for foreach, only iterables are supported.
Inline Actions

Argument of an invalid type Illuminate\Database\Eloquent\Builder<Laravel\Passport\Token> supplied for foreach, only iterables are supported.

Lint: Argument of an invalid type Illuminate\Database\Eloquent\Builder<Laravel\Passport\Token> supplied for foreach, only iterables are supported.: Argument of an invalid type Illuminate\Database\Eloquent\Builder<Laravel\Passport\Token>…
$tokenRepository->revokeAccessToken($token->id);
$refreshTokenRepository->revokeRefreshTokensByAccessTokenId($token->id);
}
machniakUnsubmitted
Done
Inline Actions

We usually do something like this:

return response()->json([
                'status' => 'success',
                'message' => \trans("app.{$this->label}-delete-success"),
        ]);
machniak: We usually do something like this: ``` return response()->json([ 'status' =>…
return response()->json([
'status' => 'success',
'message' => \trans("app.companion-deleteall-success"),
]);
}
machniakUnsubmitted
Done
Inline Actions

This line should be removed.

machniak: This line should be removed.
/**
* List devices.
*
* @return \Illuminate\Http\JsonResponse
*/
public function index()
{
$user = $this->guard()->user();
$search = trim(request()->input('search'));
$page = intval(request()->input('page')) ?: 1;
$pageSize = 20;
$hasMore = false;
$result = \App\CompanionApp::where('user_id', $user->id);
$result = $result->orderBy('created_at')
->limit($pageSize + 1)
->offset($pageSize * ($page - 1))
->get();
if (count($result) > $pageSize) {
$result->pop();
$hasMore = true;
}
// Process the result
$result = $result->map(
function ($device) {
return $device->toArray();
}
);
$result = [
'list' => $result,
'count' => count($result),
'hasMore' => $hasMore,
];
return response()->json($result);
}
/**
* Get the information about the specified companion app.
*
* @param string $id CompanionApp identifier
*
* @return \Illuminate\Http\JsonResponse
*/
public function show($id)
{
$result = \App\CompanionApp::find($id);
if (!$result) {
return $this->errorResponse(404);
}
$user = $this->guard()->user();
if ($user->id != $result->user_id) {
return $this->errorResponse(403);
}
return response()->json($result->toArray());
}
/**
machniakUnsubmitted
Done
Inline Actions

It does not return void. The description also is wrong.

machniak: It does not return void. The description also is wrong.
* Retrieve the pairing information encoded into a qrcode image.
*
* @return \Illuminate\Http\JsonResponse
*/
public function pairing()
{
$user = $this->guard()->user();
$clientIdentifier = \App\Tenant::getConfig($user->tenant_id, 'auth.companion_app.client_id');
$clientSecret = \App\Tenant::getConfig($user->tenant_id, 'auth.companion_app.client_secret');
if (empty($clientIdentifier) || empty($clientSecret)) {
\Log::warning("Empty client identifier or secret. Can't generate qr-code.");
return $this->errorResponse(500);
}
$response['qrcode'] = self::generateQRCode(
json_encode([
"serverUrl" => Utils::serviceUrl('', $user->tenant_id),
"clientIdentifier" => \App\Tenant::getConfig($user->tenant_id, 'auth.companion_app.client_id'),
"clientSecret" => \App\Tenant::getConfig($user->tenant_id, 'auth.companion_app.client_secret'),
"username" => $user->email
])
);
return response()->json($response);
}
} }