Differential D2137 Diff 6769 src/database/migrations/2021_01_14_093842_add_timespan_to_transactions_table.php

Changeset View

Standalone View

				<?php

				use Illuminate\Database\Migrations\Migration;
				use Illuminate\Database\Schema\Blueprint;
				use Illuminate\Support\Facades\Schema;

				class AddTimespanToTransactionsTable extends Migration
				{
				/**
				* Run the migrations.
				*
				* @return void
				*/
				public function up()
				{
				Schema::table('transactions', function (Blueprint $table) {
				$table->dateTimeTz('period_start')->nullable(true);
				$table->dateTimeTz('period_end')->nullable(true);
				});
				machniakUnsubmitted Done Inline Actions We're not using dateTimeTz() anywhere, we're using timestamp(). We're not using capital letters in columns names, so probably not here either. I don't like "timespan", how about `period_start` and `period_end`? machniak: 1. We're not using dateTimeTz() anywhere, we're using timestamp(). 2. We're not using capital…
				machniakUnsubmitted Not Done Inline Actions Not done. The column names are wrong. Also, what happens with the existing records? I think it should be nullable() instead of useCurrent(). machniak: Not done. The column names are wrong. Also, what happens with the existing records? I think it…
				}

				/**
				* Reverse the migrations.
				*
				* @return void
				*/
				public function down()
				{
				Schema::table('transactions', function (Blueprint $table) {
				//
				});
				machniakUnsubmitted Not Done Inline Actions Missing drop column statements. machniak: Missing drop column statements.
				}
				}