Details
Details
- Reviewers
vanmeeuwen - Commits
- rKb8a2e7a6013b: User profile (Bifrost#T331493)
Diff Detail
Diff Detail
- Repository
- rK kolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/app/Http/Controllers/API/UsersController.php | ||
|---|---|---|
| 267 | phpstan tells me update() may also return void... which is from the abort() returns? | |
| src/app/Http/Controllers/API/UsersController.php | ||
|---|---|---|
| 267 | I'll fix all API controllers code to always respond with JSON, and not use abort(). | |
| 293 | Could work untill we want to support passwords like "000000000" and other "nullable" strings. | |
| src/app/Http/Kernel.php | ||
| 22 ↗ | (On Diff #2341) | I found it problematic with input validation. Not impossible, but harder to handle . For example, user settings cannot be NULL at the moment, so to reset (set to an empty value) a setting we just POST empty strings. If they are converted to null, we need to add more code to detect that. |
Comment Actions
- Re-enable ConvertEmptyStringsToNull middleware
- Always return JSON responses from API, even on 403/404 errors