Page MenuHomePhorge

Scheduling dialog
ClosedPublic

Authored by mollekopf on Oct 15 2015, 12:54 PM.
Referenced Files
Unknown Object (File)
Feb 29 2024, 4:14 PM
Unknown Object (File)
Sep 29 2023, 2:26 AM
Unknown Object (File)
Sep 19 2023, 2:58 PM
Unknown Object (File)
Apr 30 2018, 7:08 AM
Unknown Object (File)
Apr 28 2018, 9:48 PM
Unknown Object (File)
Mar 26 2018, 8:03 AM
Unknown Object (File)
Mar 11 2018, 9:24 PM
Unknown Object (File)
Mar 11 2018, 9:23 PM
Subscribers
None

Details

Reviewers
knauss
Maniphest Tasks
Restricted Maniphest Task
Summary
  • 7c11e2f - (HEAD, kolab/integration/4.13.0) Removed some unnecessary includes. (4 minutes ago) <Christian Mollekopf>
  • a2259a1 - Reload the model if a new model is set. (4 minutes ago) <Christian Mollekopf>
  • 885feb0 - Use a calendar to select the event time. (4 minutes ago) <Christian Mollekopf>
  • f138bd5 - If we have no freebusy information all slots are free. (4 minutes ago) <Christian Mollekopf>
  • da003b7 - Make it always possible to enter the conflictresolution dialog. (3 days ago) <Christian Mollekopf>

Diff Detail

Repository
rKP kdepim
Branch
kolab/integration/4.13.0
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

mollekopf retitled this revision from to Scheduling dialog.
mollekopf updated this object.
mollekopf edited the test plan for this revision. (Show Details)
mollekopf added a reviewer: knauss.
mollekopf set the repository for this revision to rKP kdepim.
mollekopf added a project: KDE PIM.
knauss edited edge metadata.

looks good

incidenceeditor-ng/incidenceattendee.cpp
557

should not be needed

the update of the satus of the button is done in slotUpdateConflictLabel and this is updated by the conflictResolver directly:
connect( mConflictResolver, SIGNAL(conflictsDetected(int)),

this, SLOT(slotUpdateConflictLabel(int)) );

and this signal is fired whenever the fbdata is changed (if the fb data is downloaded).

incidenceeditor-ng/schedulingdialog.h
66

please get rid of spaces in new code, that makes it easier for pushing things upstream.

incidenceeditor-ng/visualfreebusywidget.cpp
107

mAgendaView = new EventViews::AgendaView(EventViews::PrefsPtr(EventViews::Prefs::instance()), QDate(), QDate(), false, false);

that makes sure, that the korganizer settings (timezone, start of workinghours etc.) are used.

This revision is now accepted and ready to land.Oct 15 2015, 4:52 PM
knauss added a task: Restricted Maniphest Task.Oct 15 2015, 6:52 PM

Submitted

incidenceeditor-ng/incidenceattendee.cpp
557

It's needed because I want the schedule dialog also to be available if no fb-data is found.