Page MenuHomePhorge

Create ActAsDialog
ClosedPublic

Authored by knauss on Aug 25 2015, 1:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 11:40 PM
Unknown Object (File)
Tue, Mar 26, 11:40 PM
Unknown Object (File)
Tue, Mar 26, 11:22 PM
Unknown Object (File)
Feb 25 2024, 8:18 AM
Unknown Object (File)
Feb 21 2024, 12:58 PM
Unknown Object (File)
Feb 15 2024, 4:26 AM
Unknown Object (File)
Feb 12 2024, 12:34 AM
Unknown Object (File)
Jan 17 2024, 1:30 PM
Subscribers
None

Details

Summary

Push actAs information to mailsystem

To set the correct sender the mailsystem needs to get this information.

Fixes wrong way when we send to the organizer/attendees

Diff Detail

Repository
rKPL kdepimlibs
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

knauss retitled this revision from to Create ActAsDialog.
knauss updated this object.
knauss added a reviewer: mollekopf.
akonadi/calendar/itiphandlerhelper_p.cpp
250 ↗(On Diff #100)

Why is this and all the related changes necessary?

akonadi/calendar/mailscheduler_p.cpp
95 ↗(On Diff #100)

whitespace

99 ↗(On Diff #100)

That should probably be performTransaction2?

mollekopf edited edge metadata.
This revision now requires changes to proceed.Aug 26 2015, 12:02 PM
akonadi/calendar/itiphandlerhelper_p.cpp
250 ↗(On Diff #100)

This was broken before - when i did the actAs work (3c2458ed6d7086) - i didn't test every codepath so i didn't saw that it is the wrong way around and without the dialog you are still not sure as whom you are acting.
With the dialog we have now full controll of the actor and so it was better to see, that we mixed up sender/recipient.

akonadi/calendar/mailscheduler_p.cpp
99 ↗(On Diff #100)

yepp, but why this complied... strange

mollekopf edited edge metadata.

Ready to ship with the requested changes.

This revision is now accepted and ready to land.Aug 27 2015, 10:55 AM
This revision was automatically updated to reflect the committed changes.