Page MenuHomePhorge
Differential D3644

Geo-lockin UI
ClosedPublic
Actions

Authored by machniak on Jun 20 2022, 9:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 5, 4:55 AM
Unknown Object (File)
Thu, Apr 4, 1:01 AM
Unknown Object (File)
Wed, Apr 3, 8:33 AM
Unknown Object (File)
Fri, Mar 29, 11:39 AM
Unknown Object (File)
Mar 12 2024, 11:34 AM
Unknown Object (File)
Mar 6 2024, 4:00 AM
Unknown Object (File)
Mar 1 2024, 7:39 AM
Unknown Object (File)
Feb 29 2024, 4:25 PM
View All 46 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKdfabb5e2e0ac: Geo-lockin UI
rK0ea3b1c42771: Geo-lockin UI
Summary

Geo-lockin UI

Also added tests for nginx controller regarding geo-lockin

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.Jun 20 2022, 9:41 AM
Harbormaster completed remote builds in B39287: Diff 10484.Jun 20 2022, 9:41 AM
machniak requested review of this revision.Jun 20 2022, 9:41 AM
machniak updated this revision to Diff 10511.Jun 28 2022, 10:24 AM
  • A better world map
  • Current location handling, style improvements
  • Map zooming
  • Geo-lockin reset button for admins/resellers
  • Merge branch 'master' into dev/geo-lock-ui
Harbormaster completed remote builds in B39323: Diff 10511.Jun 28 2022, 10:24 AM
machniak updated this revision to Diff 10517.Jun 29 2022, 9:26 AM
  • More tests
  • Secure login and password-reset with geo-lockin
Harbormaster completed remote builds in B39329: Diff 10517.Jun 29 2022, 9:26 AM
mollekopf subscribed.Jul 6 2022, 4:50 PM

I'm not sure if the required data for \App\Utils::countryForIP is actually available in production, but the UI is functional and the implementation looks good to me.

src/app/Http/Controllers/API/V4/UsersController.php
187

Is this intentional?

mollekopf accepted this revision.Jul 6 2022, 4:51 PM
This revision is now accepted and ready to land.Jul 6 2022, 4:51 PM
machniak added inline comments.Jul 6 2022, 6:41 PM
src/app/Http/Controllers/API/V4/UsersController.php
187

Yes. We hide the geo-lockin setting in the UI if user has no private beta entitlement, for now.

Closed by commit rKdfabb5e2e0ac: Geo-lockin UI (authored by machniak). · Explain WhyJul 8 2022, 12:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
17 lines
7 lines
V4/
Admin/
28 lines
23 lines
1 line
11 lines
9 lines
Traits/
23 lines
27 lines
7 lines
database/
seeds/
local/
1 line
377 lines
public/
images/
261 lines
resources/
js/
18 lines
lang/
en/
1 line
6 lines
2 lines
themes/
19 lines
53 lines
vue/
Admin/
18 lines
1 line
User/
19 lines
Widgets/
147 lines
7 lines
routes/
3 lines
tests/
9 lines
Browser/
Admin/
37 lines
Components/
117 lines
Reseller/
14 lines
36 lines
Feature/
Controller/
Admin/
27 lines
93 lines
61 lines
49 lines
Reseller/
40 lines
26 lines
11 lines

Diff 10571

View Options

src/app/Http/Controllers/API/AuthController.php

Loading...
View Options

src/app/Http/Controllers/API/PasswordResetController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/Admin/UsersController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/NGINXController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/UsersController.php

Loading...
View Options

src/app/IP4Net.php

Loading...
View Options

src/app/IP6Net.php

Loading...
View Options

src/app/Traits/UserConfigTrait.php

Loading...
View Options

src/app/User.php

Loading...
View Options

src/app/Utils.php

Loading...
View Options

src/database/seeds/local/UserSeeder.php

Loading...
View Options

src/package-lock.json

Loading...
View Options

src/public/images/world.svg

Loading...
View Options

src/resources/js/app.js

Loading...
View Options

src/resources/lang/en/app.php

Loading...
View Options

src/resources/lang/en/ui.php

Loading...
View Options

src/resources/lang/en/validation.php

Loading...
View Options

src/resources/themes/app.scss

Loading...
View Options

src/resources/themes/forms.scss

Loading...
View Options

src/resources/vue/Admin/User.vue

Loading...
View Options

src/resources/vue/Logout.vue

Loading...
View Options

src/resources/vue/User/Info.vue

Loading...
View Options

src/resources/vue/Widgets/CountrySelect.vue

Loading...
View Options

src/resources/vue/Widgets/ModalDialog.vue

Loading...
View Options

src/routes/api.php

Loading...
View Options

src/tests/Browser.php

Loading...
View Options

src/tests/Browser/Admin/UserTest.php

Loading...
View Options

src/tests/Browser/Components/CountrySelect.php

Loading...
View Options

src/tests/Browser/Reseller/UserTest.php

Loading...
View Options

src/tests/Browser/UsersTest.php

Loading...
View Options

src/tests/Feature/Controller/Admin/UsersTest.php

Loading...
View Options

src/tests/Feature/Controller/AuthTest.php

Loading...
View Options

src/tests/Feature/Controller/NGINXTest.php

Loading...
View Options

src/tests/Feature/Controller/PasswordResetTest.php

Loading...
View Options

src/tests/Feature/Controller/Reseller/UsersTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...
View Options

src/webpack.mix.js

Loading...