This patch prevents the iRony logs from being filled up with the following deprecation warning:
PHP Deprecated: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context
Details
Details
- Reviewers
machniak - Commits
- rIfd53ed716c1e: Fix deprecation-warning log spam
Diff Detail
Diff Detail
- Repository
- rI iRony
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
What distro are you using? I guess it would be better to update PEAR package. It should not throw warnings with pear-1.10.x.
Comment Actions
I didn't know this warning is fixed in newer versions of PEAR - the warning message suggested the opposite. :-)
I'm on Debian 8, which ships an older version of PEAR (see https://packages.debian.org/jessie/php-pear).
So I guess we can scratch this patch and either provide a newer version of PEAR (yay, more packages!) or patch iRony for the distros that ship PEAR < 1.10.1? If possible, I'd favour the latter because I'd like to keep the deviation from distro packages as small as possible (i.e., provide own packages only for functional reasons, not for non-functional ones).