./phpunit
Details
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rK60f8cfed258b: Don't call userResponse() on failed login
Diff Detail
Diff Detail
- Repository
- rK kolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/app/Http/Controllers/API/AuthController.php | ||
---|---|---|
171 | If the idea is that we don't call userResponse if the $user == null in a failed login case, should we then not also not set the status to 'success' ? |
src/app/Http/Controllers/API/AuthController.php | ||
---|---|---|
171 | This might be hard to see as it ended up being quite a refactoring. We had one instance where we called userResponse() before respondWithToken(). If you consider respondWithToken() could "respond" with an error (on auth failure) the heavy userResponse() call was redundant. Now we do this only on a successful response. |