Page MenuHomePhorge

Split client javascript code into core+unauthenticated and authenticated, the same for admin/reseller
ClosedPublic

Authored by machniak on Nov 10 2021, 10:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 3:38 PM
Unknown Object (File)
Feb 17 2024, 11:56 PM
Unknown Object (File)
Feb 16 2024, 1:30 PM
Unknown Object (File)
Feb 8 2024, 4:46 PM
Unknown Object (File)
Jan 30 2024, 11:49 PM
Unknown Object (File)
Jan 30 2024, 6:50 AM
Unknown Object (File)
Jan 24 2024, 7:20 PM
Unknown Object (File)
Jan 24 2024, 5:46 PM
Subscribers
Restricted Project

Details

Summary

As we're adding more and more features the client-side code grows. To make the main page still responsive
I split the code into two parts. One that is always loaded and one that is loaded only if user is authenticated.

So, before we had user.js - 493 KB, now it is user.js - 395 KB and user/pages.js 94 KB.

I also saved a few kilobytes with use of whitespace:condense option.

Test Plan

./phpunit --testsuite=Browser

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
  • Merge branch 'master' into dev/split-client

Looks reasonable, maybe a webpackPrefetch: true could make sense to enable prefetching (might be enabled by default anyways though).

The css changes seem unrelated, I trust you know what you're doing there ;-)

This revision is now accepted and ready to land.Jan 10 2022, 11:19 AM
This revision was automatically updated to reflect the committed changes.