- Display error message or any error
- Handler errors when connecting to the OpenVidu session
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rKe4a2e7060d30: Meet: Improved error handling
./phpunit
Diff Detail
- Repository
- rK kolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/resources/vue/Meet/Room.vue | ||
---|---|---|
371 | Do we need a room state label for 422 as well above? |
src/resources/vue/Meet/Room.vue | ||
---|---|---|
452 | A session.token seems to be implied by a 'ready' state. Can we somehow loose the token? |
src/resources/vue/Meet/Room.vue | ||
---|---|---|
371 | I don't think so. A 422 response should contain the 3xx code response in the json data. In normal circumstances there will be no 422 response without the 3xx code in json response. | |
452 | No, you can't loose the (main) token. Here we're preventing from calling initSession() again if the token has been already acquired. It's needed because after openvidu connection error we might end up in joinSession() again. |
See comment why I'm not entirely clear why we don't require the roomStateLabel but nevertheless require a special case for 422, but looks good enough.
src/resources/vue/Meet/Room.vue | ||
---|---|---|
371 | I don't follow. It seems to me this.roomState can be equal to 422, and in this case it seems like there should be a corresponding label, unless the label is somehow not displayed, in which case I don't get why we need to make an exception for 422. If you are certain it's correct, that's fine by me. |