Page MenuHomePhorge
Differential D1984

Separate subscribers list
ClosedPublic
Actions

Authored by machniak on Dec 22 2020, 12:26 PM.
Tags
None
Referenced Files
F11761551: D1984.diff
Tue, Apr 16, 6:57 PM
Unknown Object (File)
Fri, Apr 12, 11:40 AM
Unknown Object (File)
Thu, Apr 4, 3:28 AM
Unknown Object (File)
Mar 16 2024, 9:29 PM
Unknown Object (File)
Mar 16 2024, 10:18 AM
Unknown Object (File)
Mar 10 2024, 11:57 AM
Unknown Object (File)
Mar 7 2024, 5:19 AM
Unknown Object (File)
Mar 4 2024, 9:29 AM
View All 27 Files
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK2f6b39562c74: Separate subscribers list
Summary

with small css class/functions naming improvements

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.Dec 22 2020, 12:26 PM
Harbormaster completed remote builds in B32182: Diff 5422.Dec 22 2020, 12:26 PM
machniak requested review of this revision.Dec 22 2020, 12:26 PM
machniak updated this revision to Diff 5458.Dec 24 2020, 8:59 AM
  • Small API change, controller tests
  • Fix browser tests regressions
  • Add browser tests for subscribers feature
  • Rename some css classes and functions to more appropriate names
Harbormaster completed remote builds in B32218: Diff 5458.Dec 24 2020, 8:59 AM
machniak edited the summary of this revision. (Show Details)Dec 24 2020, 9:00 AM
vanmeeuwen accepted this revision.Dec 24 2020, 3:19 PM
This revision is now accepted and ready to land.Dec 24 2020, 3:19 PM
Closed by commit rK2f6b39562c74: Separate subscribers list (authored by machniak, committed by vanmeeuwen). · Explain WhyDec 24 2020, 4:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
13 lines
1 line
OpenVidu/
19 lines
resources/
js/
meet/
261 lines
themes/
137 lines
vue/
Meet/
10 lines
Widgets/
4 lines
tests/
Browser/
Meet/
65 lines
16 lines
121 lines
Pages/
Meet/
3 lines
Feature/
Controller/
13 lines
1 line

Diff 5476

View Options

src/app/Http/Controllers/API/V4/OpenViduController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/UsersController.php

Loading...
View Options

src/app/OpenVidu/Room.php

Loading...
View Options

src/resources/js/meet/app.js

Loading...
View Options

src/resources/themes/meet.scss

Loading...
View Options

src/resources/vue/Meet/Room.vue

Loading...
View Options

src/resources/vue/Widgets/StatusMessage.vue

Loading...
View Options

src/tests/Browser/Meet/RoomControlsTest.php

Loading...
View Options

src/tests/Browser/Meet/RoomSecurityTest.php

Loading...
View Options

src/tests/Browser/Meet/RoomSetupTest.php

Loading...
View Options

src/tests/Browser/Pages/Meet/Room.php

Loading...
View Options

src/tests/Feature/Controller/OpenViduTest.php

Loading...
View Options

src/tests/TestCaseDusk.php

Loading...