Differential D188

Fix issue with re-binding to an LDAP connection (T1318)
ClosedPublic
Actions

Authored by machniak on Jun 21 2016, 11:26 AM.

Details

Reviewers

vanmeeuwen

Group Reviewers

PyKolab Developers

Maniphest Tasks

T1318: Fix issue with re-binding to an LDAP connection

Commits

rP58e6400583bb: Fix issue with re-binding to an LDAP connection (T1318)
rP9dafa8b521b0: Fix issue with re-binding to an LDAP connection (T1318)

Summary

Fixes T1318

Note that set_entry_attributes() will now use two LDAP connections, which may
or may not be what we want. I didn't find a simple way of using ldap_priv connection
in entry_dn() and get_entry_attributes().

Diff Detail

Repository

rP pykolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak updated this revision to Diff 411.Jun 21 2016, 11:26 AM

machniak retitled this revision from to Fix issue with re-binding to an LDAP connection (T1318).

machniak updated this object.

machniak edited the test plan for this revision. (Show Details)

machniak added a reviewer: PyKolab Developers.

machniak added a task: T1318: Fix issue with re-binding to an LDAP connection.

Get rid of unbind() and close ldap_priv connection on disconnect()

Call self._bind() before using self.entry_dn() method. @FIXME: _bind() should
probably be called explicitely by entry_dn()

vanmeeuwen accepted this revision.Jun 29 2016, 11:21 AM

vanmeeuwen added a reviewer: vanmeeuwen.

This revision is now accepted and ready to land.Jun 29 2016, 11:21 AM

Closed by commit rP9dafa8b521b0: Fix issue with re-binding to an LDAP connection (T1318) (authored by machniak, committed by vanmeeuwen). · Explain WhyJun 29 2016, 11:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

pykolab/

auth/

ldap/

__init__.py

65 lines

Diff 419

View Options

Fix issue with re-binding to an LDAP connection (T1318)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 419

pykolab/auth/ldap/__init__.py

Fix issue with re-binding to an LDAP connection (T1318)
ClosedPublic
Actions

Revision Contents
Changeset List

pykolab/auth/ldap/init.py