Page MenuHomePhorge

Fix timeSpan for a series with exceptions
ClosedPublic

Authored by knauss on May 25 2016, 7:37 PM.
Tags
None
Referenced Files
F11586267: D160.id.diff
Thu, Mar 28, 2:30 PM
Unknown Object (File)
Sun, Mar 24, 10:01 AM
Unknown Object (File)
Feb 23 2024, 11:54 PM
Unknown Object (File)
Feb 2 2024, 5:36 PM
Unknown Object (File)
Feb 2 2024, 4:13 PM
Unknown Object (File)
Jan 22 2024, 11:22 AM
Unknown Object (File)
Jan 19 2024, 8:40 PM
Unknown Object (File)
Jan 19 2024, 4:05 AM
Subscribers
None

Details

Summary

When having a time series with exceptions, that have the ThisAndFurute argument,
we need also to take this into account if we calucate the iterator for occurences
for a timespan, that begins after the exception has started.

Diff Detail

Repository
rKPL kdepimlibs
Branch
kolab/integration/4.13.0
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 3719
Build 3702: arc lint + arc unit

Event Timeline

knauss retitled this revision from to Fix timeSpan for a series with exceptions.
knauss updated this object.
knauss added a reviewer: mollekopf.
mollekopf edited edge metadata.
mollekopf added inline comments.
kcalcore/occurrenceiterator.cpp
112

lastInc and lastOffset seem to be unused?
Either remove, or otherwise you probably also have to adjust lastInc when setting the exception on incidence.

This revision now requires changes to proceed.Jun 8 2016, 2:01 PM
kcalcore/occurrenceiterator.cpp
112

No lastInc and lastOffset are used later on in the next for loop ( l151, l162).

So we can move the two variables back to ther further position. But on the other side lastOffset and lastInc are used internally in the for loop and only need to valid if resetIncidence is True.

IMO I think just leave it like i did now, because otherwise we would mix cleanup & patching.

mollekopf edited edge metadata.

Makes sense

This revision is now accepted and ready to land.Jun 9 2016, 11:52 AM
This revision was automatically updated to reflect the committed changes.