Page MenuHomePhorge

Return the result immediately if we run out of memory
ClosedPublic

Authored by mollekopf on Apr 30 2020, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 9:31 AM
Unknown Object (File)
Sat, Apr 6, 1:52 PM
Unknown Object (File)
Fri, Apr 5, 11:10 AM
Unknown Object (File)
Feb 10 2024, 7:00 PM
Unknown Object (File)
Feb 8 2024, 1:10 PM
Unknown Object (File)
Feb 6 2024, 9:55 PM
Unknown Object (File)
Feb 6 2024, 5:30 PM
Unknown Object (File)
Jan 25 2024, 4:28 AM
Subscribers
None

Details

Summary

If we don't:

  • we was a bunch of cpu because we'll be going over the entire list of

remaining messages to see if any fit (potentially over and over)

  • we end up with out of order results (which is suppose should be

technically ok)

The only thing this change makes worse is that we potentially add
another roundtrip because we didn't include a smaller message that would
have still fit in the same batch.

Diff Detail

Repository
rS syncroton
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 11:50 AM
This revision was automatically updated to reflect the committed changes.