Page MenuHomePhorge

Avoid sending the body on flag change
Needs ReviewPublic

Authored by mollekopf on Wed, May 8, 1:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 16, 5:10 AM
Unknown Object (File)
Thu, May 16, 4:08 AM
Unknown Object (File)
Mon, May 13, 11:41 PM
Unknown Object (File)
Sun, May 12, 9:29 PM
Unknown Object (File)
Sat, May 11, 7:59 PM
Unknown Object (File)
Fri, May 10, 10:21 AM
Subscribers

Details

Reviewers
machniak
Group Reviewers
Syncroton Developers
Summary

It's not completely minimal, but much closer:

<Change>
    <ServerId>38b950ebd62cd9a66929c89615d0fc04::37</ServerId>
    <ApplicationData>
        <DateReceived xmlns="uri:Email">2024-05-08T10:57:47.000Z</DateReceived>
        <From xmlns="uri:Email">Sync 1 &lt;user@domain.tld&gt;</From>
        <InternetCPID xmlns="uri:Email">65001</InternetCPID>
        <Subject xmlns="uri:Email">test sync</Subject>
        <To xmlns="uri:Email">To 1 &lt;kolab1@domain.tld&gt;,To 2 &lt;kolab2@domain.tld&gt;</To>
        <Read xmlns="uri:Email">0</Read>
        <Flag xmlns="uri:Email"/>
    </ApplicationData>
</Change>

Should be a major perforamnce enhancer if e.g. a lot of tags are used.

Diff Detail

Repository
rS syncroton
Branch
master
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 47223
Build 17970: arc lint + arc unit

Event Timeline

mollekopf created this revision.
lib/kolab_sync_data_email.php
263

This shouldn't be here.

machniak subscribed.
machniak added inline comments.
lib/kolab_sync_data_email.php
258

I think this needs ?? false.

263

This shouldn't be here.

All above, $prefs, comment and console() call.

264

Instead of duplicating this code here, just move the one from line 503 up (to around line 252).

This revision now requires changes to proceed.Thu, May 16, 8:19 AM

Cleanup according to comments