PHP 8 fixes
ClosedPublic
Actions

Authored by mollekopf on Jan 24 2023, 1:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 18, 7:11 AM

	Unknown Object (File)
	Sat, May 18, 5:53 AM

	Unknown Object (File)
	Wed, May 8, 8:49 PM

	Unknown Object (File)
	Wed, May 8, 7:19 PM

	Unknown Object (File)
	Sat, May 4, 11:31 AM

	Unknown Object (File)
	Sun, Apr 21, 5:05 PM

	Unknown Object (File)
	Sun, Apr 21, 5:05 PM

	Unknown Object (File)
	Sun, Apr 21, 5:05 PM

Subscribers

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rACa9bf8b439f88: PHP 8 fixes

Repository

rAC autoconf

Lint

Lint Not Applicable

Unit

Tests Not Applicable

mollekopf requested review of this revision.Jan 24 2023, 1:34 PM

mollekopf created this revision.

mollekopf added a reviewer: Restricted Project.Jan 24 2023, 1:34 PM

machniak requested changes to this revision.Jan 25 2023, 2:51 PM

machniak subscribed.

machniak added inline comments.

lib/Autodiscover.php
162	If $host is null str_replace() will throw a warning, no? Better to use empty string. Anyway, I don't see how is it possible to have `$params[0]` to be null/not-set?
169	This is not the same. What if the config is an empty string for some reason?
lib/AutodiscoverMicrosoft.php
166	Again, this is not the same.